All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@mandrakesoft.com>
To: Tom Leete <tleete@mountain.net>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
	Andre Hedrick <andre@linux-ide.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Athlon-SMP compiles & runs. inline fns honored.
Date: Sat, 10 Feb 2001 16:29:45 -0500	[thread overview]
Message-ID: <3A85B2C9.56F7221D@mandrakesoft.com> (raw)
In-Reply-To: <3A8554FA.AB33BE05@mountain.net>

Tom Leete wrote:
> 
> Hi Alan
> 
> I found one way to break the circularity. The association of type and struct
> definitions with interlocking inline functions caused the problem. This
> extracts task_struct from linux/sched.h to its own header,
> linux/task_struct.h. There are a few modifications elsewhere to support
> this. I'm not sure all the changes were necessary, but they are working as I
> write:
[long patch snipped]

Ouch.  What about un-inlining in_interrupt() for all SMP cases?  Reduces
code size just a bit, and function calls aren't very expensive on SMP
machines IMHO...  (and as a side effect solves this problem...)

	Jeff


-- 
Jeff Garzik       | "You see, in this world there's two kinds of
Building 1024     |  people, my friend: Those with loaded guns
MandrakeSoft      |  and those who dig. You dig."  --Blondie
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

  parent reply	other threads:[~2001-02-10 21:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-02-10 14:49 [PATCH] Athlon-SMP compiles & runs. inline fns honored Tom Leete
2001-02-10 15:13 ` Manfred Spraul
2001-02-10 15:34   ` Tom Leete
2001-02-10 21:29 ` Jeff Garzik [this message]
2001-02-11 10:54   ` Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3A85B2C9.56F7221D@mandrakesoft.com \
    --to=jgarzik@mandrakesoft.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=andre@linux-ide.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tleete@mountain.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.