From: Jeff Garzik <jgarzik@mandrakesoft.com>
To: Arnaldo Carvalho de Melo <acme@conectiva.com.br>
Cc: Andrey Panin <pazke@orbita.don.sitek.net>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/char/serial.c unchecked ioremap() calls
Date: Fri, 23 Feb 2001 09:15:29 -0500 [thread overview]
Message-ID: <3A967081.5CDF5797@mandrakesoft.com> (raw)
In-Reply-To: <20010223105359.A20170@orbita1.ru> <20010223064543.C12444@conectiva.com.br>
Arnaldo Carvalho de Melo wrote:
>
> Em Fri, Feb 23, 2001 at 10:53:59AM +0300, Andrey Panin escreveu:
> >
> > Hi all,
> >
> > 16x50 serial driver doesn't check ioremap() return value.
> > Atached patch should fix this it.
>
> humm, have not checked, but it seems as if you don't release the previous
> successful mappings on failure. Wipe out this message if I was too quick to
> answer and this is not true. 8)
Also, the proper return from a failed ioremap is -ENOMEM, so I think
Andrey's serial.c patch should modify some functions to return a failure
code...
Jeff
--
Jeff Garzik | "You see, in this world there's two kinds of
Building 1024 | people, my friend: Those with loaded guns
MandrakeSoft | and those who dig. You dig." --Blondie
next prev parent reply other threads:[~2001-02-23 14:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-02-23 7:53 [PATCH] drivers/char/serial.c unchecked ioremap() calls Andrey Panin
2001-02-23 9:45 ` Arnaldo Carvalho de Melo
2001-02-23 14:15 ` Jeff Garzik [this message]
2001-02-26 15:06 ` Andrey Panin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3A967081.5CDF5797@mandrakesoft.com \
--to=jgarzik@mandrakesoft.com \
--cc=acme@conectiva.com.br \
--cc=linux-kernel@vger.kernel.org \
--cc=pazke@orbita.don.sitek.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.