All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@mandrakesoft.com>
To: Steven Walter <srwalter@yahoo.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: serial driver not properly detecting modem
Date: Tue, 24 Apr 2001 07:04:48 -0400	[thread overview]
Message-ID: <3AE55DD0.D4C334D7@mandrakesoft.com> (raw)
In-Reply-To: <20010423223847.A3945@hapablap.dyn.dhs.org>

Steven Walter wrote:
> 
> It would seem that I have a modem (hardware based, not winmodem) of
> PCI_CLASS_COMMUNICATION_OTHER.  This, unfortunately, prevents it from
> being automagically detected by the serial driver, which only looks for
> devices of 
> 
> I've fixed this here merely by adding an entry to the PCI table of
> serial.c for PCI_CLASS_COMMUNICATION_OTHER.  Is this the best way to fix
> this?  Is there some reason that this shouldn't be done in general?  If
> not, I'd like to see it fix in the kernel proper.

That won't work for a general rule, since winmodems list themselves as
'OTHER' too.  Just add your PCI id above the
PCI_CLASS_COMMUNICATION_SERIAL.

Make sure you cc me and tytso@mit.edu on such a patch...

-- 
Jeff Garzik      | The difference between America and England is that
Building 1024    | the English think 100 miles is a long distance and
MandrakeSoft     | the Americans think 100 years is a long time.
                 |      (random fortune)

  reply	other threads:[~2001-04-24 11:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-04-24  3:38 serial driver not properly detecting modem Steven Walter
2001-04-24 11:04 ` Jeff Garzik [this message]
2001-04-24 13:38 ` Alan Cox
2001-04-24 13:46   ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3AE55DD0.D4C334D7@mandrakesoft.com \
    --to=jgarzik@mandrakesoft.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=srwalter@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.