From: Abramo Bagnara <abramo@alsa-project.org>
To: Jeff Garzik <jgarzik@mandrakesoft.com>
Cc: "David S. Miller" <davem@redhat.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Linux Kernel Development <linux-kernel@vger.kernel.org>,
Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: unsigned long ioremap()?
Date: Thu, 03 May 2001 10:53:08 +0200 [thread overview]
Message-ID: <3AF11C74.F679F6F8@alsa-project.org> (raw)
In-Reply-To: <Pine.LNX.4.05.10105030852330.9438-100000@callisto.of.borg> <15089.979.650927.634060@pizda.ninka.net> <3AF10E80.63727970@alsa-project.org> <3AF11211.B226543D@mandrakesoft.com> <3AF11953.54BBE72B@alsa-project.org> <3AF11A7E.9184627C@mandrakesoft.com>
Jeff Garzik wrote:
>
> Abramo Bagnara wrote:
> > > > That's indeed the reason to change ioremap prototype for 2.5.
> > >
> > > Say what??
> > >
> >
> > Please give a look
> > http://www.uwsg.indiana.edu/hypermail/linux/kernel/0008.1/0338.html
> > http://www.uwsg.indiana.edu/hypermail/linux/kernel/0008.1/0407.html
> >
> > This was something that already got a wide consent.
>
> Let's not return unsigned long -- DaveM's suggestion is far better.
> unsigned long is not opaque enough, IMHO.
I'm not sure to understand what's the proposed way to do offsetting:
#define IO_ADDR(cookie, ofs)?
(maybe with #define IO_SADDR(cookie, struct_name, field))
Others?
--
Abramo Bagnara mailto:abramo@alsa-project.org
Opera Unica Phone: +39.546.656023
Via Emilia Interna, 140
48014 Castel Bolognese (RA) - Italy
ALSA project http://www.alsa-project.org
It sounds good!
next prev parent reply other threads:[~2001-05-03 8:53 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-05-03 6:55 unsigned long ioremap()? Geert Uytterhoeven
2001-05-03 7:08 ` David S. Miller
2001-05-03 7:18 ` Jeff Garzik
2001-05-03 7:29 ` C.Praveen
2001-05-03 7:46 ` Jonathan Lundell
2001-05-03 7:57 ` Geert Uytterhoeven
2001-05-03 7:53 ` Abramo Bagnara
2001-05-03 8:08 ` Jeff Garzik
2001-05-03 8:26 ` Geert Uytterhoeven
2001-05-03 8:39 ` Abramo Bagnara
2001-05-03 8:44 ` Jeff Garzik
2001-05-03 8:53 ` Abramo Bagnara [this message]
2001-05-03 9:45 ` David Woodhouse
2001-05-03 9:57 ` Abramo Bagnara
2001-05-04 0:22 ` David S. Miller
2001-05-04 7:15 ` Abramo Bagnara
2001-05-04 7:30 ` David S. Miller
2001-05-04 11:07 ` Abramo Bagnara
2001-05-04 13:53 ` Jonathan Lundell
2001-05-13 14:00 ` Jes Sorensen
2001-05-13 14:38 ` Abramo Bagnara
2001-05-03 10:02 ` David Woodhouse
2001-05-03 7:33 ` Jonathan Lundell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3AF11C74.F679F6F8@alsa-project.org \
--to=abramo@alsa-project.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=davem@redhat.com \
--cc=geert@linux-m68k.org \
--cc=jgarzik@mandrakesoft.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.