From: Jeff Garzik <jgarzik@mandrakesoft.com>
To: Keith Owens <kaos@ocs.com.au>
Cc: Andrzej Krzysztofowicz <ankry@green.mif.pg.gda.pl>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] 2.4.4-ac11 network drivers cleaning
Date: Sat, 19 May 2001 22:22:01 -0400 [thread overview]
Message-ID: <3B072A49.B44B0F2A@mandrakesoft.com> (raw)
In-Reply-To: <12098.990324222@ocs3.ocs-net>
Keith Owens wrote:
>
> On Sat, 19 May 2001 17:58:49 -0400,
> Jeff Garzik <jgarzik@mandrakesoft.com> wrote:
> >Finally, I don't know if I mentioned this earlier, but to be complete
> >and optimal, version strings should be a single variable 'version', such
> >that it can be passed directly to printk like
> >
> > printk(version);
>
> Nit pick. That has random side effects if version contains any '%'
> characters. Make it
>
> printk("%s\n", version);
>
> Not quite as optimal but safer.
I disagree. Don't work around an escape bug in a version string, fix
it...
--
Jeff Garzik | "Do you have to make light of everything?!"
Building 1024 | "I'm extremely serious about nailing your
MandrakeSoft | step-daughter, but other than that, yes."
next prev parent reply other threads:[~2001-05-20 2:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-05-19 21:41 [PATCH] 2.4.4-ac11 network drivers cleaning Andrzej Krzysztofowicz
2001-05-19 21:58 ` Jeff Garzik
2001-05-20 2:03 ` Keith Owens
2001-05-20 2:22 ` Jeff Garzik [this message]
2001-05-20 19:43 ` Alan Cox
2001-05-20 13:35 ` Andrzej Krzysztofowicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3B072A49.B44B0F2A@mandrakesoft.com \
--to=jgarzik@mandrakesoft.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=ankry@green.mif.pg.gda.pl \
--cc=kaos@ocs.com.au \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.