All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tim Hockin <thockin@sun.com>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: /dev/nvram driver
Date: Fri, 22 Jun 2001 11:50:40 -0700	[thread overview]
Message-ID: <3B339380.C0D973CB@sun.com> (raw)

Who is maintaining the /dev/nvram driver?  I have a couple things I want to
suggest/ask.  

Currently it tracks O_EXCL on open() and sets a flag, whereby no other
open() calls can succeed.  Is this functionality really needed?  Perhaps it
should just be a reader/writer model : n readers or 1 writer.  In that
case, should open() block on a writer, or return -EBUSY?

nvram_release() calls lock_kernel() - any particular reason?

various other bits (nvram_open_cnt, for example) are not SMP safe.  I'm
making sure it is safe now.

What I really want to know is: should I bother making nvram_open_cnt SMP
safe, or should it just go away all together.  I vote for the latter
option, unless something depends on this behavior (in which case, other
fixes are needed, because it is broken :).

comments?


-- 
Tim Hockin
Systems Software Engineer
Sun Microsystems, Cobalt Server Appliances
thockin@sun.com

             reply	other threads:[~2001-06-22 18:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-06-22 18:50 Tim Hockin [this message]
2001-06-22 19:02 ` /dev/nvram driver Jeff Garzik
2001-06-22 22:07 ` Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3B339380.C0D973CB@sun.com \
    --to=thockin@sun.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.