From: Jeff Garzik <jgarzik@mandrakesoft.com>
To: Andrew Morton <andrewm@uow.edu.au>
Cc: Tobias Ringstrom <tori@unhappy.mine.nu>,
Kernel Mailing List <linux-kernel@vger.kernel.org>,
mochel@transmeta.com, Linus Torvalds <torvalds@transmeta.com>
Subject: Re: WOL with 3c59x and 2.4.6-pre6 breaks WOL
Date: Mon, 02 Jul 2001 12:02:59 -0400 [thread overview]
Message-ID: <3B409B33.E672C5BC@mandrakesoft.com> (raw)
In-Reply-To: <Pine.LNX.4.33.0106291257180.3935-200000@boris.prodako.se> <3B4096D9.36F40BF4@uow.edu.au>
Andrew Morton wrote:
> --- linux-2.4.6-pre8/drivers/pci/pci.c Sun Jul 1 16:11:25 2001
> +++ linux-akpm/drivers/pci/pci.c Tue Jul 3 01:28:35 2001
> @@ -425,7 +425,7 @@ int pci_enable_wake(struct pci_dev *dev,
>
> if (enable) value |= PCI_PM_CTRL_PME_STATUS;
> else value &= ~PCI_PM_CTRL_PME_STATUS;
> -
> + value |= PCI_PM_CTRL_PME_ENABLE;
> pci_write_config_word(dev, pm + PCI_PM_CTRL, value);
>
> return 0;
wrong but it seems you spotted a bug in the code -- set/clear _ENABLE
right above your change here. maybe read and write _STATUS
unconditionally, for paranoia.
--
Jeff Garzik | The LSB is a bunch of crap.
Building 1024 | E-mail for details.
MandrakeSoft |
prev parent reply other threads:[~2001-07-02 16:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-06-29 14:04 WOL with 3c59x and 2.4.6-pre6 breaks WOL Tobias Ringstrom
2001-07-02 15:44 ` Andrew Morton
2001-07-02 16:02 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3B409B33.E672C5BC@mandrakesoft.com \
--to=jgarzik@mandrakesoft.com \
--cc=andrewm@uow.edu.au \
--cc=linux-kernel@vger.kernel.org \
--cc=mochel@transmeta.com \
--cc=tori@unhappy.mine.nu \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.