From: Jeff Garzik <jgarzik@mandrakesoft.com>
To: paulus@samba.org
Cc: linux-kernel@vger.kernel.org, torvalds@transmeta.com,
dhinds@zen.stanford.edu
Subject: Re: Memory region check in drivers/pcmcia/rsrc_mgr.c
Date: Sat, 07 Jul 2001 07:51:11 -0400 [thread overview]
Message-ID: <3B46F7AF.5D677F1D@mandrakesoft.com> (raw)
In-Reply-To: <15174.62880.772230.734585@tango.paulus.ozlabs.org>
Paul Mackerras wrote:
> In drivers/pcmcia/rsrc_mgr.c, there is code that check whether a given
> range of PCI memory addresses are available for the pcmcia code to
> use. This code uses a macro, check_mem_resource(), to check whether a
> particular region is available, defined like this:
>
> #define check_mem_resource(b,n) check_resource(&iomem_resource, (b), (n))
[...]
> I think that
> we should be using check_mem_region instead,
AFAICS you are correct.
check_xxx is deprecated, though. Is it possible to move a request_xxx
earlier in the logic?
check_xxx is inherently racy.
--
Jeff Garzik | A recent study has shown that too much soup
Building 1024 | can cause malaise in laboratory mice.
MandrakeSoft |
next prev parent reply other threads:[~2001-07-07 11:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-07-07 11:42 Memory region check in drivers/pcmcia/rsrc_mgr.c Paul Mackerras
2001-07-07 11:51 ` Jeff Garzik [this message]
2001-07-07 18:13 ` Linus Torvalds
2001-07-08 8:32 ` Paul Mackerras
2001-07-08 16:36 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3B46F7AF.5D677F1D@mandrakesoft.com \
--to=jgarzik@mandrakesoft.com \
--cc=dhinds@zen.stanford.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=paulus@samba.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.