All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tim Hockin <thockin@sun.com>
To: Studierende der Universitaet des Saarlandes 
	<masp0008@stud.uni-sb.de>,
	groudier@club-internet.fr, alan@redhat.com,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH]  sym53c8xx timer rework
Date: Tue, 10 Jul 2001 11:21:57 -0700	[thread overview]
Message-ID: <3B4B47C5.F176C3C2@sun.com> (raw)
In-Reply-To: <3B4ACF6B.5F194E54@stud.uni-saarland.de>

Studierende der Universitaet des Saarlandes wrote:

> > +       NCR_LOCK_NCB(np, flags);
> > +       del_timer(&np->timer);
> > +       NCR_UNLOCK_NCB(np, flags);
> 
> I'm only reading the diff, but this change looks wrong.
> The simplest solution is del_timer_sync() instead of
> LOCK;del_timer;UNLOCK.

I didn't even realize there was a del_timer_sync().  That does what is
needed.  3 lines become 1, I guess.

Thanks, CC:ed to Gerard and crew.

-- 
Tim Hockin
Systems Software Engineer
Sun Microsystems, Cobalt Server Appliances
thockin@sun.com

  reply	other threads:[~2001-07-10 18:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-07-10  9:48 [PATCH] sym53c8xx timer rework Studierende der Universitaet des Saarlandes
2001-07-10 18:21 ` Tim Hockin [this message]
  -- strict thread matches above, loose matches on Subject: below --
2001-07-10  7:19 Tim Hockin
2001-07-10 19:00 ` Gérard Roudier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3B4B47C5.F176C3C2@sun.com \
    --to=thockin@sun.com \
    --cc=alan@redhat.com \
    --cc=groudier@club-internet.fr \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masp0008@stud.uni-sb.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.