From: Thomas Sailer <sailer@scs.ch>
To: Pete Zaitcev <zaitcev@redhat.com>
Cc: johannes@erdfelt.com, linux-kernel@vger.kernel.org
Subject: Re: Patch for bizzare oops in USB
Date: Mon, 20 Aug 2001 13:59:37 +0200 [thread overview]
Message-ID: <3B80FBA9.556B7B2B@scs.ch> (raw)
In-Reply-To: <20010818013101.A7058@devserv.devel.redhat.com>
Pete Zaitcev schrieb:
> diff -ur -X dontdiff linux-2.4.8/drivers/usb/usb.c linux-2.4.8-e/drivers/usb/usb.c
> --- linux-2.4.8/drivers/usb/usb.c Tue Jul 24 14:20:56 2001
> +++ linux-2.4.8-e/drivers/usb/usb.c Fri Aug 17 22:03:27 2001
> @@ -1066,7 +1066,7 @@
>
> awd.wakeup = &wqh;
> init_waitqueue_head(&wqh);
> - current->state = TASK_INTERRUPTIBLE;
> + current->state = TASK_UNINTERRUPTIBLE; /* MUST BE SO. -- zaitcev */
> add_wait_queue(&wqh, &wait);
> urb->context = &awd;
> status = usb_submit_urb(urb);
This is bad for other users of usb_control_msg/usb_bulk_msg that depend on
the sleep to be interruptible. Instead of bouncing back and forth whether
those routines shall sleep interruptibly or uninterruptibly, we should either
provide two routines or a parameter that specifies whether the sleep
shall be interruptible, or create a local version of usb_control_msg
if ov511 is the only user requiring uninterruptible sleep.
Tom
next prev parent reply other threads:[~2001-08-20 11:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-08-18 5:31 Patch for bizzare oops in USB Pete Zaitcev
2001-08-20 11:59 ` Thomas Sailer [this message]
2001-08-20 21:06 ` Pete Zaitcev
2001-08-21 8:29 ` Thomas Sailer
2001-08-20 21:44 ` Pete Zaitcev
2001-08-21 4:01 ` Johannes Erdfelt
2001-08-21 4:17 ` Pete Zaitcev
2001-08-20 22:12 ` Eugene Crosser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3B80FBA9.556B7B2B@scs.ch \
--to=sailer@scs.ch \
--cc=johannes@erdfelt.com \
--cc=linux-kernel@vger.kernel.org \
--cc=t.sailer@alumni.ethz.ch \
--cc=zaitcev@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.