From: Arjan van de Ven <arjanv@redhat.com>
To: Per Niva <pna@mendosus.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Added devfs support for i386 msr/cpuid driver
Date: Mon, 27 Aug 2001 12:16:47 +0100 [thread overview]
Message-ID: <3B8A2C1F.63AF4AE7@redhat.com> (raw)
In-Reply-To: <Pine.LNX.4.33.0108271031010.12684-102000@subcentral.mendosus.org>
>
> int __init msr_init(void)
> {
> +#ifdef CONFIG_DEVFS_FS
> + devfs_handle = devfs_register(NULL, "cpu/msr", DEVFS_FL_DEFAULT, 0, 0,
> + S_IFREG | S_IRUGO | S_IWUSR,
> + &msr_fops, NULL);
> +#else
> if (register_chrdev(MSR_MAJOR, "cpu/msr", &msr_fops)) {
> printk(KERN_ERR "msr: unable to get major %d for msr\n",
> MSR_MAJOR);
> return -EBUSY;
> }
> +#endif
this must be wrong as you don't check for devfs_register failures...
Also why devfs can't just use register_chrdev and not touch ALL drivers
is beyond me, but it has been like that for a while now...
next prev parent reply other threads:[~2001-08-27 11:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-08-27 8:43 [PATCH] Added devfs support for i386 msr/cpuid driver Per Niva
2001-08-27 11:16 ` Arjan van de Ven [this message]
2001-08-27 14:52 ` Richard Gooch
2001-08-27 14:55 ` Per Niva
2001-09-03 19:57 ` Richard Gooch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3B8A2C1F.63AF4AE7@redhat.com \
--to=arjanv@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pna@mendosus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.