From: Manfred Spraul <manfred@colorfullife.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cache colour task_structs
Date: Thu, 01 Nov 2001 11:49:23 +0100 [thread overview]
Message-ID: <3BE128B3.F93D8A6A@colorfullife.com> (raw)
In-Reply-To: <E15z6HM-0005gW-00@the-village.bc.nu>
Alan Cox wrote:
>
> > The attached patch moves the task structure into a slab, with normal
> > cache colouring.
> > It's tested with i386 SMP.(i.e. it boots and runs X)
>
> Keeping the stack and task struct together is smarter. You fix the one
> problem but not the other horror.
>
If we keep both together we are limited to 8 kB for stack, task
structure and slack for colouring - I'm not sure if that won't cause
stack overruns. We are already down to 6.3 kB stack.
> We need to perturb esp colour too. It might be the right way to do this
> is slab based kernel stacks, it might be that your code is cheaper than
> the cost of getting current the really hard way and we should just add
> random numbers to the initial esp of a task ?
>
Adding a random amount would be a one line change to copy_thread.
--
Manfred
next prev parent reply other threads:[~2001-11-01 10:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-10-31 19:27 [PATCH] cache colour task_structs Manfred Spraul
2001-11-01 1:04 ` Alan Cox
2001-11-01 10:49 ` Manfred Spraul [this message]
[not found] <3BE050AD.C6D7CE4B@colorfullife.com.suse.lists.linux.kernel>
[not found] ` <E15z6HM-0005gW-00@the-village.bc.nu.suse.lists.linux.kernel>
2001-11-01 1:43 ` Andi Kleen
2001-11-01 2:18 ` Davide Libenzi
2001-11-01 4:42 ` Keith Owens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3BE128B3.F93D8A6A@colorfullife.com \
--to=manfred@colorfullife.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.