From: "Peter Wächtler" <pwaechtler@loewe-komp.de>
To: Mike Castle <dalgoda@ix.netcom.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: File System Performance
Date: Tue, 13 Nov 2001 10:56:54 +0100 [thread overview]
Message-ID: <3BF0EE66.FC5DA9CD@loewe-komp.de> (raw)
In-Reply-To: <3BF04926.2080009@free.fr> <Pine.LNX.4.33.0111121411410.7555-100000@penguin.transmeta.com> <3BF04ED8.8A9280B5@zip.com.au> <20011112150420.B6749@thune.mrc-home.com>
Mike Castle wrote:
>
> On Mon, Nov 12, 2001 at 02:36:08PM -0800, Andrew Morton wrote:
> > /* Detect if outputting to "/dev/null". */
> > {
> > static char const dev_null[] = "/dev/null";
> > struct stat dev_null_stat;
> >
> > dev_null_output =
> > (strcmp (archive_name_array[0], dev_null) == 0
> > || (! _isrmt (archive)
> > && stat (dev_null, &dev_null_stat) == 0
> > && S_ISCHR (archive_stat.st_mode)
> > && archive_stat.st_rdev == dev_null_stat.st_rdev));
> > }
> >
> > It's actually a bug. I may _want_ an ISREG /dev/null...
>
> Doesn't the S_ISCHR() handle that case?
>
No. It is: if (A || B)
If A is true, B is not even evaluated.
next prev parent reply other threads:[~2001-11-13 9:58 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-11-12 13:54 File System Performance Ben Israel
2001-11-12 16:33 ` Andrew Morton
2001-11-12 17:50 ` Ben Israel
2001-11-12 19:46 ` Andrew Morton
2001-11-12 19:59 ` Richard Gooch
2001-11-12 23:07 ` Mike Fedyk
2001-11-13 0:04 ` Richard Gooch
2001-11-13 0:08 ` Mike Fedyk
2001-11-13 0:26 ` Richard Gooch
2001-11-13 0:47 ` Mike Castle
2001-11-13 1:28 ` Mike Fedyk
2001-11-13 6:34 ` Richard Gooch
2001-11-13 20:56 ` Andreas Dilger
2001-11-13 7:45 ` Andreas Dilger
2001-11-12 20:06 ` Steve Lord
2001-11-12 20:41 ` Andrew Morton
2001-11-12 21:27 ` Steve Lord
2001-11-12 21:43 ` Andrew Morton
2001-11-12 21:45 ` Steve Lord
2001-11-12 21:48 ` Linus Torvalds
2001-11-12 22:11 ` Lionel Bouton
2001-11-12 19:41 ` Gérard Roudier
2001-11-12 22:14 ` Linus Torvalds
2001-11-12 22:30 ` Ragnar Kjørstad
2001-11-12 22:36 ` Andrew Morton
2001-11-12 23:04 ` Mike Castle
2001-11-13 9:56 ` Peter Wächtler [this message]
2001-11-13 9:41 ` Henning P. Schmiedehausen
2001-11-12 22:16 ` Andrew Morton
2001-11-12 22:26 ` Steve Lord
2001-11-12 22:32 ` Lionel Bouton
2001-11-12 22:45 ` Alan Cox
2001-11-12 22:39 ` Alan Cox
2001-11-12 22:39 ` Xavier Bestel
2001-11-12 22:46 ` Mike Castle
2001-11-12 21:53 ` Lionel Bouton
2001-11-13 0:17 ` Andreas Dilger
2001-11-13 0:40 ` Peter J . Braam
2001-11-13 20:46 ` Andreas Dilger
2001-11-16 22:07 ` Peter J . Braam
2001-11-16 23:14 ` Mike Fedyk
2001-11-12 16:40 ` Ben Israel
2001-11-12 17:29 ` Andrew Morton
-- strict thread matches above, loose matches on Subject: below --
2001-11-12 22:36 Grant Erickson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3BF0EE66.FC5DA9CD@loewe-komp.de \
--to=pwaechtler@loewe-komp.de \
--cc=dalgoda@ix.netcom.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.