All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@mandrakesoft.com>
To: David Weinehall <tao@acc.umu.se>
Cc: Benjamin LaHaise <bcrl@redhat.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] reformat mtrr.c to conform to CodingStyle
Date: Wed, 14 Nov 2001 03:15:49 -0500	[thread overview]
Message-ID: <3BF22835.FBEA8D66@mandrakesoft.com> (raw)
In-Reply-To: <20011112232539.A14409@redhat.com> <20011113121022.L1778@lynx.no> <20011114085714.V17761@khan.acc.umu.se>

David Weinehall wrote:
> I don't think Lindent does everything 100% correct; at least its
> formatting of switch/case does look a little fishy:
> 
>         switch (option) {
>         case 1:
>                 /* blaha */
> 
> That feels kind of odd compared to the rest of the codingstyle.
> 
> Comments?!

hehe now we really get into personal preference.

I like the above case statement style, because I see no value in
additional indentation.  The code is presented one level deeper than the
switch statement, which is key.  'case' keywords merely separate the
properly-indented code.  IMHO of course :)

-- 
Jeff Garzik      | Only so many songs can be sung
Building 1024    | with two lips, two lungs, and one tongue.
MandrakeSoft     |         - nomeansno


  parent reply	other threads:[~2001-11-14  8:16 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-11-13  4:25 [PATCH] reformat mtrr.c to conform to CodingStyle Benjamin LaHaise
2001-11-13 17:04 ` Linus Torvalds
2001-11-13 19:05   ` Chris Wedgwood
2001-11-13 19:11     ` Jeff Garzik
2001-11-14 10:42     ` Helge Hafting
2001-11-14 15:30       ` Jeff Garzik
2001-11-14 16:56         ` Christoph Hellwig
2001-11-13 19:10 ` Andreas Dilger
2001-11-13 19:18   ` Benjamin LaHaise
2001-11-13 19:21   ` Momchil Velikov
2001-11-13 19:21   ` Jeff Garzik
2001-11-14  7:57   ` David Weinehall
2001-11-14  8:04     ` David S. Miller
2001-11-14  8:15     ` Jeff Garzik [this message]
2001-11-20  8:47     ` Mark van Walraven
2001-11-20  9:52       ` David Weinehall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3BF22835.FBEA8D66@mandrakesoft.com \
    --to=jgarzik@mandrakesoft.com \
    --cc=bcrl@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tao@acc.umu.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.