From: Till Immanuel Patzschke <tip@internetwork-ag.de>
To: "David S. Miller" <davem@redhat.com>
Cc: linux-kernel@vger.kernel.org, paulus@samba.org,
linux-ppp@vger.kernel.org
Subject: Re: [PATCH] ppp_generic causes skput:under: w/ pppoatm andvc-encaps
Date: Wed, 14 Nov 2001 12:13:10 +0100 [thread overview]
Message-ID: <3BF251C6.23CD1243@internetwork-ag.de> (raw)
In-Reply-To: <3BF190F0.3FB26BD0@internetwork-ag.de> <20011113.210221.55509229.davem@redhat.com>
"David S. Miller" wrote:
> From: Till Immanuel Patzschke <tip@internetwork-ag.de>
> Date: Tue, 13 Nov 2001 22:30:24 +0100
>
> I've attached a patch, checking for headroom first, and - if necessary -
> reallocating a larger buffer for the skb_push.
>
> Please check and apply - or find a better fix!
>
> Here is my "better fix". In pppoatm, we should be increasing the
> device header length appropriately. ie. dev->hard_header_len needs to
> be increased in the pppoatm driver when vc-encaps is used.
that is - of course - a more pppoatm specific fix BUT my concern ist that
PPP requires (!) to have at least 2 bytes headroom [when using PPP_FILTER]
(which is NOT noted), and isn't it good practice to check for room before
claiming it?
--
Till Immanuel Patzschke mailto: tip@internetwork-ag.de
interNetwork AG Phone: +49-(0)611-1731-121
Bierstadter Str. 7 Fax: +49-(0)611-1731-31
D-65189 Wiesbaden Web: http://www.internetwork-ag.de
next prev parent reply other threads:[~2001-11-14 11:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-11-13 21:30 [PATCH] ppp_generic causes skput:under: w/ pppoatm and vc-encaps Till Immanuel Patzschke
2001-11-14 5:02 ` David S. Miller
2001-11-14 11:13 ` Till Immanuel Patzschke [this message]
2001-11-14 11:48 ` [PATCH] ppp_generic causes skput:under: w/ pppoatm andvc-encaps David S. Miller
2001-11-14 14:23 ` [PATCH] ppp_generic causes skput:under: w/ pppoatm and vc-encaps Michal Ostrowski
2001-11-14 14:28 ` David S. Miller
2001-11-14 14:41 ` Till Immanuel Patzschke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3BF251C6.23CD1243@internetwork-ag.de \
--to=tip@internetwork-ag.de \
--cc=davem@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-ppp@vger.kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.