From: Jeff Garzik <jgarzik@mandrakesoft.com>
To: Linus Torvalds <torvalds@transmeta.com>
Cc: Andrew Morton <akpm@zip.com.au>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Scalable page cache
Date: Mon, 26 Nov 2001 17:49:22 -0500 [thread overview]
Message-ID: <3C02C6F2.71A581AB@mandrakesoft.com> (raw)
In-Reply-To: <Pine.LNX.4.33.0111261421320.10706-100000@penguin.transmeta.com>
Linus Torvalds wrote:
>
> On Mon, 26 Nov 2001, Andrew Morton wrote:
> >
> > We've called block_prepare_write(), which has done the kmap.
> > But even though block_prepare_write() returned success, this
> > call to the filesystem's ->prepare_write() is about to fail.
>
> That's _way_ too intimate knowledge of how block_prepare_write() works (or
> doesn't work).
>
> How about sending me a patch that removes all the kmap/kunmap crap from
> _both_ ext3 and block_prepare/commit_write.
FWIW Al Viro pointed out to me yesterday that block_xxx are really
nothing but helpers... Depending on them doing or not doing certain
things is IMHO ok...
If the behavior of the helpers is not what is desired, you are free to
ignore them and roll your own... or wrap them as it appears ext3 is
doing here.
Jeff
--
Jeff Garzik | Only so many songs can be sung
Building 1024 | with two lips, two lungs, and one tongue.
MandrakeSoft | - nomeansno
next prev parent reply other threads:[~2001-11-26 22:49 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-11-26 12:31 [PATCH] Scalable page cache Momchil Velikov
2001-11-26 17:22 ` Ingo Molnar
2001-11-26 17:23 ` Momchil Velikov
2001-11-26 18:16 ` Benjamin LaHaise
2001-11-26 18:42 ` Rik van Riel
2001-11-26 20:29 ` Ingo Molnar
2001-11-26 18:33 ` David S. Miller
2001-11-26 19:29 ` Andrew Morton
2001-11-26 19:35 ` David S. Miller
2001-11-26 18:34 ` Benjamin LaHaise
2001-11-26 20:40 ` Ingo Molnar
2001-11-26 19:19 ` Benjamin LaHaise
2001-11-26 21:00 ` Ingo Molnar
2001-11-26 20:43 ` Daniel Phillips
2001-11-26 19:49 ` Ingo Molnar
2001-11-26 18:08 ` Christoph Hellwig
2001-11-26 20:13 ` Ingo Molnar
2001-11-26 21:09 ` Ingo Molnar
2001-11-26 19:18 ` David S. Miller
2001-11-26 19:45 ` Andrew Morton
2001-11-26 19:57 ` David S. Miller
2001-11-26 20:03 ` Andrew Morton
2001-11-26 20:37 ` Linus Torvalds
2001-11-26 21:02 ` Andrew Morton
2001-11-26 22:23 ` Linus Torvalds
2001-11-26 22:49 ` Jeff Garzik [this message]
2001-11-26 23:06 ` Linus Torvalds
2001-11-26 21:10 ` Ingo Molnar
2001-11-26 17:29 ` Linus Torvalds
2001-11-26 20:03 ` Ingo Molnar
2001-11-26 18:02 ` David S. Miller
2001-11-26 18:11 ` Rik van Riel
2001-11-27 8:07 ` benchmark results: " Anton Blanchard
2001-11-26 18:52 ` [PATCH] " Daniel Phillips
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3C02C6F2.71A581AB@mandrakesoft.com \
--to=jgarzik@mandrakesoft.com \
--cc=akpm@zip.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.