From: Jeff Garzik <jgarzik@mandrakesoft.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Zwane Mwaikambo <zwane@linux.realnet.co.sz>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] if (foo) kfree(foo) /fs cleanup
Date: Sat, 01 Dec 2001 07:49:21 -0500 [thread overview]
Message-ID: <3C08D1D1.F3EAC851@mandrakesoft.com> (raw)
In-Reply-To: <E16A9WI-00073W-00@the-village.bc.nu>
Alan Cox wrote:
>
> IMHO this is precisely the wrong thing to do.
>
> We should make the = NULL check within kfree do a BUG() call. That way we
> fix the cases not being considered instead of hiding real bugs
I actually agree with the general sentiment, but,
Then you have to fix all the code which has assumed such, breaking
previously-correct code. bcrl (IIRC) was the one who told me about
kfree doing the NULL check; likewise akpm for brelse. So people are
using these things.
Do you really want to audit every single kfree and brelse to implement
this change?
--
Jeff Garzik | Only so many songs can be sung
Building 1024 | with two lips, two lungs, and one tongue.
MandrakeSoft | - nomeansno
next prev parent reply other threads:[~2001-12-01 12:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-12-01 11:36 [PATCH] if (foo) kfree(foo) /fs cleanup Zwane Mwaikambo
2001-12-01 12:45 ` Alan Cox
2001-12-01 12:49 ` Jeff Garzik [this message]
2001-12-01 13:10 ` Zwane Mwaikambo
2001-12-01 16:33 ` [PATCH] if (foo) kfree(foo) /fs cleanup + reverted JBD code path changes Zwane Mwaikambo
2001-12-01 17:14 ` OGAWA Hirofumi
2001-12-01 17:48 ` Zwane Mwaikambo
2001-12-01 18:05 ` OGAWA Hirofumi
2001-12-01 18:13 ` Zwane Mwaikambo
[not found] ` <Pine.LNX.4.33.0112011830550.14290-100000@netfinity.realnet.co.s z>
2001-12-01 17:40 ` Alex Bligh - linux-kernel
2001-12-01 18:02 ` Zwane Mwaikambo
2001-12-01 18:11 ` Zwane Mwaikambo
2001-12-01 20:40 ` Raja R Harinath
2001-12-01 21:25 ` Francois Romieu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3C08D1D1.F3EAC851@mandrakesoft.com \
--to=jgarzik@mandrakesoft.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=zwane@linux.realnet.co.sz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.