From: Andrew Morton <akpm@zip.com.au>
To: Matthew Dharm <mdharm-kernel@one-eyed-alien.net>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Fwd: Hard Lockup on 2.4.16 with Via ieee1394 (sbp2 mode)
Date: Fri, 28 Dec 2001 20:59:17 -0800 [thread overview]
Message-ID: <3C2D4DA5.E688FF43@zip.com.au> (raw)
In-Reply-To: <200112290321.fBT3GCSs007627@svr3.applink.net> <3C2D3DBB.6ADE1CC5@zip.com.au>, <3C2D3DBB.6ADE1CC5@zip.com.au>; from akpm@zip.com.au on Fri, Dec 28, 2001 at 07:51:23PM -0800 <20011228204041.A14736@one-eyed-alien.net>
Matthew Dharm wrote:
>
> Hrm...
>
> Does this apply to usb-storage also? Under what conditions do you need to
> hold the io_request_lock when calling the done function?
>
That's scsi_old_done(). I don't think scsi_done() cares whether
io_request_lock is held or not.
And io_request_lock *must* be held by the caller of scsi_old_done() - it
assumes this. I think we'd have heard by now if usb was getting this
wrong. Looks like it's using scsi_done(), yes?
-
next prev parent reply other threads:[~2001-12-29 5:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-12-29 3:13 Fwd: Hard Lockup on 2.4.16 with Via ieee1394 (sbp2 mode) Timothy Covell
2001-12-29 3:51 ` Andrew Morton
2001-12-29 4:40 ` Matthew Dharm
2001-12-29 4:59 ` Andrew Morton [this message]
2001-12-29 5:11 ` Matthew Dharm
2001-12-29 6:17 ` Timothy Covell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3C2D4DA5.E688FF43@zip.com.au \
--to=akpm@zip.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=mdharm-kernel@one-eyed-alien.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.