From: Martin Dalecki <dalecki@evision-ventures.com>
To: Linus Torvalds <torvalds@transmeta.com>
Cc: Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: [PATCH] usabe2-2.5.2-pre6
Date: Thu, 03 Jan 2002 16:11:07 +0100 [thread overview]
Message-ID: <3C34748B.1050500@evision-ventures.com> (raw)
In-Reply-To: <Pine.LNX.4.33.0201011402560.13397-100000@penguin.transmeta.com>
[-- Attachment #1: Type: text/plain, Size: 660 bytes --]
The attached patch is making the SCSI "mid-layer" vomit bag usable again.
I have fixed some very ugly offenders as well in due course:
1. Moved the "informative" scsi_device_types[MAX_SCSI_DEVICE_CODE];
2. Unneccessary/inappriopriate locking in ppa.c
3. "Write only" field in Scsi_CD struct:
unsigned readcd_cdda:1; /* reading audio data using READ_CD */
It get's only set but is never used and never needed.
After having a look at this SCSI code I really got the opinnion that it
was written
buy someone who didn't know what functions and local variables are good for.
Everything there seems to be done in a maximally terse style...
Anyway.
[-- Attachment #2: usable2-2.5.2-pre6.gz --]
[-- Type: application/x-gzip, Size: 6775 bytes --]
next prev parent reply other threads:[~2002-01-03 15:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-01-01 22:15 NFS "dev_t" issues Linus Torvalds
2002-01-01 22:38 ` [PATCH] " Jeff Garzik
2002-01-01 22:41 ` Linus Torvalds
2002-01-01 22:57 ` Alexander Viro
2002-01-01 23:27 ` Linus Torvalds
2002-01-01 23:04 ` [PATCH] " Jeff Garzik
2002-01-01 23:26 ` Linus Torvalds
2002-01-01 23:49 ` Jeff Garzik
2002-01-02 5:45 ` Greg KH
2002-01-02 16:05 ` [PATCH] Make 2.5.2-pre6 usable Martin Dalecki
2002-01-03 15:11 ` Martin Dalecki [this message]
2002-01-07 16:50 ` NFS "dev_t" issues Trond Myklebust
2002-01-08 9:29 ` PATCH 2.5.2-pre9 scsi cleanup Martin Dalecki
2002-01-09 4:05 ` GOTO Masanori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3C34748B.1050500@evision-ventures.com \
--to=dalecki@evision-ventures.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.