All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@mandrakesoft.com>
To: Alessandro Suardi <alessandro.suardi@oracle.com>
Cc: linux-kernel@vger.kernel.org, andries.brouwer@cwi.nl,
	torvalds@transmeta.com
Subject: Re: 2.5.2-pre7 still missing bits of kdev_t
Date: Thu, 03 Jan 2002 19:13:30 -0500	[thread overview]
Message-ID: <3C34F3AA.23431926@mandrakesoft.com> (raw)
In-Reply-To: <3C34F1E4.5B0FC1D9@oracle.com>

Alessandro Suardi wrote:
> ./fs/reiserfs/inode.c
> ./fs/reiserfs/super.c
> ./fs/reiserfs/journal.c
> ./include/linux/reiserfs_fs.h

reiserfs is blindly storing the kernel's kdev_t value raw to disk.

AFAICS this will need a policy decision not just cleanup, before it
works in 2.5.2 properly.  If we switch the kernel to 12:20 major:minor
numbers, suddenly the reiserfs disk format changes based on kernel
version, and earlier kernels see corrupted major:minor numbers.

For many filesystems with just 16-bits of major/minor storage, they
store the raw kdev_t value as well, but have different problems when
12:20 comes around.

If reiserfs guys had planned ahead they would be decoding the
major/minor number before it hits disk, and already storing it in 12:20
fashion or somesuch.

Unless I am missing something...

	Jeff


-- 
Jeff Garzik      | Only so many songs can be sung
Building 1024    | with two lips, two lungs, and one tongue.
MandrakeSoft     |         - nomeansno

  reply	other threads:[~2002-01-04  0:13 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-01-04  0:05 2.5.2-pre7 still missing bits of kdev_t Alessandro Suardi
2002-01-04  0:13 ` Jeff Garzik [this message]
2002-01-04  2:32   ` Linus Torvalds
2002-01-04  6:52     ` Jeff Garzik
2002-01-04 16:45       ` Linus Torvalds
2002-01-04 17:34         ` Nikita Danilov
2002-01-04 17:51           ` Jeff Garzik
2002-01-04 17:53             ` Linus Torvalds
2002-01-04 18:11               ` Alexander Viro
  -- strict thread matches above, loose matches on Subject: below --
2002-01-04  1:47 Andries.Brouwer
2002-01-04 13:21 Andries.Brouwer
2002-01-04 19:24 Andries.Brouwer
2002-01-04 21:10 ` Alexander Viro
2002-01-04 21:14   ` Linus Torvalds
2002-01-05  0:10     ` Alan Cox
2002-01-04 19:32 Andries.Brouwer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3C34F3AA.23431926@mandrakesoft.com \
    --to=jgarzik@mandrakesoft.com \
    --cc=alessandro.suardi@oracle.com \
    --cc=andries.brouwer@cwi.nl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.