All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@zip.com.au>
To: David Weinehall <tao@acc.umu.se>
Cc: Richard Gooch <rgooch@ras.ucalgary.ca>,
	Ivan Passos <ivan@cyclades.com>,
	linux-kernel@vger.kernel.org
Subject: Re: Serial Driver Name Question (kernels 2.4.x)
Date: Mon, 07 Jan 2002 22:23:04 -0800	[thread overview]
Message-ID: <3C3A9048.CB80061A@zip.com.au> (raw)
In-Reply-To: <3C38BC19.72ECE86@zip.com.au>, <3C34024A.EDA31D24@zip.com.au> <3C33E0D3.B6E932D6@zip.com.au> <3C33BCF3.20BE9E92@cyclades.com> <200201030637.g036bxe03425@vindaloo.ras.ucalgary.ca> <200201062012.g06KCIu16158@vindaloo.ras.ucalgary.ca> <3C38BC19.72ECE86@zip.com.au> <200201070636.g076asR25565@vindaloo.ras.ucalgary.ca> <3C3A7DA7.381D033D@zip.com.au>, <3C3A7DA7.381D033D@zip.com.au>; from akpm@zip.com.au on Mon, Jan 07, 2002 at 09:03:35PM -0800 <20020108071548.J5235@khan.acc.umu.se>

David Weinehall wrote:
> 
> On Mon, Jan 07, 2002 at 09:03:35PM -0800, Andrew Morton wrote:
> > [ tty driver name breakage ]
> >
> > Richard, can we please get this wrapped up?
> >
> > My preferred approach is to change the driver naming scheme
> > so that we don't have to put printf control-strings everywhere.
> > We can remove a number of ifdefs that way.
> 
> Wouldn't it be cleaner to have:
> 
> #ifdef CONFIG_DEVFS_FS
>         serial_driver.name = "tts/";
> #else
>         serial_driver.name = "tts";
> #endif
> 
> and
> 
>         sprintf("buf, "%s%d", name, idx + tty->driver.name_base);
> 
> respectively?!
> 

Well, with the scheme I proposed most drivers won't need the
ifdef.  It'll just be:

	serial_driver.name = "cua";

With devfs enabled that expands to cua/42.  Without devfs it expands
to cua42.

Seems that some drivers have had their name changed when used under
devfs (tts/%d versus ttyS%d).  But a lot have not.

-

  reply	other threads:[~2002-01-08  6:28 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-01-03  2:07 Serial Driver Name Question (kernels 2.4.x) Ivan Passos
2002-01-03  4:40 ` Andrew Morton
2002-01-03  6:37   ` Richard Gooch
2002-01-03  7:03     ` Andrew Morton
2002-01-06 20:12       ` Richard Gooch
2002-01-06 20:36         ` Alan Cox
2002-01-06 20:27           ` Richard Gooch
2002-01-06 21:05         ` Andrew Morton
2002-01-07  6:36           ` Richard Gooch
2002-01-07  7:20             ` Andrew Morton
2002-01-08  5:03             ` Andrew Morton
2002-01-08  6:15               ` David Weinehall
2002-01-08  6:23                 ` Andrew Morton [this message]
2002-01-08 18:54                   ` Ivan Passos
2002-01-08 21:58                   ` Michael H. Warfield
2002-01-08 22:11                     ` Andrew Morton
2002-01-08 23:33                       ` Ivan Passos
2002-01-09 16:36                         ` Richard Gooch
2002-01-10  9:14                           ` Nick Craig-Wood
2002-01-08 18:47               ` Ivan Passos
2002-01-03 16:32   ` Ivan Passos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3C3A9048.CB80061A@zip.com.au \
    --to=akpm@zip.com.au \
    --cc=ivan@cyclades.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rgooch@ras.ucalgary.ca \
    --cc=tao@acc.umu.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.