From: Andrew Morton <akpm@zip.com.au>
To: Benjamin LaHaise <bcrl@redhat.com>
Cc: Hugh Dickins <hugh@veritas.com>,
Marcelo Tosatti <marcelo@conectiva.com.br>,
Andrea Arcangeli <andrea@suse.de>, Dave Jones <davej@suse.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pagecache lock ordering
Date: Thu, 10 Jan 2002 15:47:37 -0800 [thread overview]
Message-ID: <3C3E2819.6A3AAD77@zip.com.au> (raw)
In-Reply-To: <3C3CE5D6.2204BD27@zip.com.au> <Pine.LNX.4.21.0201101332560.1121-100000@localhost.localdomain> <3C3DFBEF.BA050536@zip.com.au>, <3C3DFBEF.BA050536@zip.com.au>; from akpm@zip.com.au on Thu, Jan 10, 2002 at 12:39:11PM -0800 <20020110182804.D8433@redhat.com>
Benjamin LaHaise wrote:
>
> On Thu, Jan 10, 2002 at 12:39:11PM -0800, Andrew Morton wrote:
> > I'm struggling to see a use for generic_buffer_fdatasync(). Maybe
> > for a filesystem which doesn't implement ->writepage()? Dunno.
>
> I seem to be using it in aio. Well, at least code based on it which
> seems to work for most filesystems for O_DATASYNC...
>
You seem to be using writeout_one_page(). What I was
thinking of was:
- Kill generic_buffer_fdatasync().
- Move writeout_one_page() into fs/buffer.c
- Move waitfor_one_page() into fs/buffer.c. This is just
for completeness; I expect this function will have no
callers soon. __iodesc_sync_wait_page() could use it though.
OK by you?
-
next prev parent reply other threads:[~2002-01-10 23:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-01-10 0:42 [PATCH] pagecache lock ordering Hugh Dickins
2002-01-10 0:52 ` Andrew Morton
2002-01-10 14:06 ` Hugh Dickins
2002-01-10 20:39 ` Andrew Morton
2002-01-10 23:28 ` Benjamin LaHaise
2002-01-10 23:47 ` Andrew Morton [this message]
2002-01-10 23:54 ` Benjamin LaHaise
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3C3E2819.6A3AAD77@zip.com.au \
--to=akpm@zip.com.au \
--cc=andrea@suse.de \
--cc=bcrl@redhat.com \
--cc=davej@suse.de \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.