From: Manfred Spraul <manfred@colorfullife.com>
To: linux-kernel@vger.kernel.org
Cc: Andre Hedrick <andre@linuxdiskcert.org>, Andrew Morton <akpm@zip.com.au>
Subject: Re: block completion races
Date: Wed, 16 Jan 2002 17:55:08 +0100 [thread overview]
Message-ID: <3C45B06C.5AA45DCD@colorfullife.com> (raw)
> Also, there is this code in ide_do_drive_cmd():
>
> if (action == ide_wait) {
> wait_for_completion(&wait); /* wait for it to be serviced */
> return rq->errors ? -EIO : 0; /* return -EIO if errors */
> }
>
> Is it safe to use `rq' here? It has just been recycled in
> end_that_request_last() and we don't own it any more.
>
Yes, this is safe. rq lies on the stack of the caller of
ide_do_drive_cmd() - it can't disappear before we return.
--
Manfred
next reply other threads:[~2002-01-16 16:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-01-16 16:55 Manfred Spraul [this message]
2002-01-16 18:50 ` block completion races Jens Axboe
-- strict thread matches above, loose matches on Subject: below --
2002-01-16 1:50 Andrew Morton
2002-01-16 4:11 ` Andre Hedrick
2002-01-16 7:09 ` Jens Axboe
2002-01-16 7:07 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3C45B06C.5AA45DCD@colorfullife.com \
--to=manfred@colorfullife.com \
--cc=akpm@zip.com.au \
--cc=andre@linuxdiskcert.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.