From: Nicolas Aspert <Nicolas.Aspert@epfl.ch>
To: Didier Moens <moensd@xs4all.be>,
Marcelo Tosatti <marcelo@conectiva.com.br>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH]Re: OOPS in APM 2.4.18-pre4 with i830MP agpgart
Date: Sat, 19 Jan 2002 09:44:10 +0100 [thread overview]
Message-ID: <3C4931DA.5020703@epfl.ch> (raw)
In-Reply-To: <3C487E68.1000404@xs4all.be>
[-- Attachment #1: Type: text/plain, Size: 674 bytes --]
Didier Moens wrote:
> Dear all,
>
> On november 27th, Nicolas Aspert was so kind as to post a modification
> to agpgart, which catters for detection of the Intel i830MP.
>
> The patch was included in 2.4.18-pre2.
>
> Unfortunately, loading agpgart yields an oops when APM ("apm -s") is
> invoked, both in terminal and in X. APM functions perfectly when agpgart
> is absent.
>
>
>
Hello all
Here is a patch that fixes the APM/suspend/resume issues in agpgart (for
820 and 830MP chipsets).
The patch is against 2.4.18-pre4
Have a nice week-end.
Nicolas
--
Nicolas Aspert Signal Processing Laboratory (LTS)
Swiss Federal Institute of Technology (EPFL)
[-- Attachment #2: patch-agp_suspend_resume-2.4.18-pre4 --]
[-- Type: text/plain, Size: 1108 bytes --]
diff -Nru linux-2.4.18-pre4.clean/drivers/char/agp/agpgart_be.c linux-2.4.18-pre4.dirty/drivers/char/agp/agpgart_be.c
--- linux-2.4.18-pre4.clean/drivers/char/agp/agpgart_be.c Sat Jan 19 09:35:00 2002
+++ linux-2.4.18-pre4.dirty/drivers/char/agp/agpgart_be.c Sat Jan 19 09:38:41 2002
@@ -1857,7 +1857,10 @@
agp_bridge.free_by_type = agp_generic_free_by_type;
agp_bridge.agp_alloc_page = agp_generic_alloc_page;
agp_bridge.agp_destroy_page = agp_generic_destroy_page;
-
+ agp_bridge.suspend = agp_generic_suspend;
+ agp_bridge.resume = agp_generic_resume;
+ agp_bridge.cant_use_aperture = 0;
+
return 0;
(void) pdev; /* unused */
@@ -1887,7 +1890,10 @@
agp_bridge.free_by_type = agp_generic_free_by_type;
agp_bridge.agp_alloc_page = agp_generic_alloc_page;
agp_bridge.agp_destroy_page = agp_generic_destroy_page;
-
+ agp_bridge.suspend = agp_generic_suspend;
+ agp_bridge.resume = agp_generic_resume;
+ agp_bridge.cant_use_aperture = 0;
+
return 0;
(void) pdev; /* unused */
next prev parent reply other threads:[~2002-01-19 8:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-01-18 19:58 OOPS in APM 2.4.18-pre4 with i830MP agpgart Didier Moens
2002-01-18 20:25 ` Alan Cox
2002-01-18 20:25 ` Nicolas Aspert
2002-01-18 20:28 ` Dave Jones
2002-01-18 20:40 ` Didier Moens
2002-01-18 20:39 ` Nicolas Aspert
2002-01-19 8:44 ` Nicolas Aspert [this message]
2002-01-19 21:50 ` [PATCH]Re: " Didier Moens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3C4931DA.5020703@epfl.ch \
--to=nicolas.aspert@epfl.ch \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
--cc=moensd@xs4all.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.