Re: [PATCH] amiga input api drivers

[Roman Zippel <zippel@linux-m68k.org>]

Hi,

James Simmons wrote:

> +       printk(amikbd_messages[scancode]);      /* scancodes >= 0x78 are error codes */

Damn, Geert was faster with this. :)

> +       for (i = 0; i < 0x78; i++)
> +               if (amikbd_keycode[i])
> +                       set_bit(amikbd_keycode[i], amikbd_dev.keybit);

Do I understand it correctly, that amikbd_keycode[i] must have non zero
value for a valid key? If yes, something must be wrong here:

> +static unsigned char amikbd_keycode[0x78] = {
> +         0,  2,  3,  4,  5,  6,  7,  8,  9, 10, 11, 12, 13, 43,  0, 82,

0 is a valid keycode on the Amiga, it should be KEY_GRAVE.

bye, Roman