From: Matthias Grimm <joker@cymes.de>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: LinuxPPC-Dev <linuxppc-dev@lists.linuxppc.org>
Subject: [PATCH] Superflous code in mac_hid.c
Date: Mon, 04 Feb 2002 20:09:24 +0100 [thread overview]
Message-ID: <3C5EDC64.9050405@cymes.de> (raw)
Hi Ben,
The following patch deletes some code lines in mac_hid.c which were from
my point of view an copy-&-paste artefact from char/pc_keyb.c.
--- drivers/macintosh/mac_hid.c.orig Thu Feb 4 01:06:49 1904
+++ drivers/macintosh/mac_hid.c Mon Feb 4 12:10:30 2002
@@ -363,11 +363,9 @@
prev_scancode = 0;
return 0;
}
-
} else {
+
} else
prev_scancode = 0;
-
if (scancode == 0x2a || scancode == 0x36)
-
return 0;
-
}
+
if (e0_keys[scancode])
*keycode = e0_keys[scancode];
else {
----------------
The code is only nessecary to fix a misbehaviour of a special pc
keyboard as described in char/pc_keyb.c. I think it's not relevant
for macintosh computers.
The reason to delete this lines is that two scancodes can't be used.
I found this problem, as I tried to assign the Keycode 209 to the Fn-Key
for test purposes. After all translations and mappings the key sequence
0xe0 0x36 was generated and quashed by this code lines.
This is a low priority and temporary patch (until the new input device is
fully integrated in the kernel), but temporary solutions mostly have
incredible livespans. ;-)
Kind regards
Matthias Grimm
** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/
reply other threads:[~2002-02-04 19:09 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3C5EDC64.9050405@cymes.de \
--to=joker@cymes.de \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@lists.linuxppc.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.