From: Andrew Morton <akpm@zip.com.au>
To: Hugh Dickins <hugh@veritas.com>
Cc: Marcelo Tosatti <marcelo@conectiva.com.br>,
Benjamin LaHaise <bcrl@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] __free_pages_ok oops
Date: Wed, 06 Feb 2002 11:47:47 -0800 [thread overview]
Message-ID: <3C618863.DA7AC3B9@zip.com.au> (raw)
In-Reply-To: <Pine.LNX.4.21.0202061844450.1856-100000@localhost.localdomain>
Hugh Dickins wrote:
>
> Sorry, no solution, but maybe another oops in __free_pages_ok might help?
What problem are you trying to solve?
>
> --- 2.4.18-pre8/mm/page_alloc.c Tue Feb 5 12:55:36 2002
> +++ linux/mm/page_alloc.c Wed Feb 6 18:31:07 2002
> @@ -73,9 +73,11 @@
> /* Yes, think what happens when other parts of the kernel take
> * a reference to a page in order to pin it for io. -ben
> */
> - if (PageLRU(page))
> + if (PageLRU(page)) {
> + if (in_interrupt())
> + BUG();
> lru_cache_del(page);
> -
> + }
Yes. lru_cache_del() in interrupt context will deadlock on SMP
or wreck the LRU list on UP. I can't see how we can ever perform
the final release of a PageLRU page in interrupt context but I agree
this test is a good one.
-
next prev parent reply other threads:[~2002-02-06 19:48 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-02-06 19:06 [PATCH] __free_pages_ok oops Hugh Dickins
2002-02-06 19:47 ` Andrew Morton [this message]
2002-02-06 20:15 ` Hugh Dickins
2002-02-06 21:11 ` Andrew Morton
2002-02-07 20:31 ` Manfred Spraul
2002-02-07 5:09 ` Benjamin LaHaise
2002-02-07 5:47 ` Andrew Morton
2002-02-07 5:55 ` David S. Miller
2002-02-07 6:19 ` Andrew Morton
2002-02-07 6:49 ` David S. Miller
2002-02-07 7:07 ` Andrew Morton
2002-02-07 11:52 ` Hugh Dickins
2002-02-07 12:34 ` Rik van Riel
2002-02-07 12:37 ` David S. Miller
2002-02-07 12:44 ` Rik van Riel
2002-02-07 13:19 ` Hugh Dickins
2002-02-07 13:27 ` Rik van Riel
2002-02-07 13:55 ` Daniel Phillips
2002-02-07 14:28 ` Hugh Dickins
2002-02-07 14:56 ` Rik van Riel
2002-02-07 20:21 ` Hugh Dickins
2002-02-07 20:58 ` Andrea Arcangeli
2002-02-07 21:09 ` Andrew Morton
2002-02-07 22:18 ` Andrea Arcangeli
2002-02-07 22:31 ` Andrew Morton
2002-02-07 23:09 ` Andrea Arcangeli
2002-02-07 23:27 ` Andrew Morton
2002-02-08 17:46 ` Hugh Dickins
2002-02-09 14:14 ` Gerd Knorr
2002-02-09 15:47 ` arjan
2002-02-09 14:33 ` Benjamin LaHaise
2002-02-12 20:19 ` Hugh Dickins
2002-02-13 18:52 ` Marcelo Tosatti
2002-02-14 10:47 ` Hugh Dickins
2002-02-14 11:10 ` Gerd Knorr
2002-02-14 13:10 ` Andrea Arcangeli
2002-02-14 14:01 ` Hugh Dickins
2002-02-14 15:17 ` Andrea Arcangeli
2002-02-14 16:27 ` Linus Torvalds
2002-02-25 18:32 ` Benjamin LaHaise
2002-02-25 19:35 ` Linus Torvalds
2002-02-07 9:48 ` Benjamin LaHaise
-- strict thread matches above, loose matches on Subject: below --
2002-02-09 8:52 alad
2002-02-09 10:46 ` Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3C618863.DA7AC3B9@zip.com.au \
--to=akpm@zip.com.au \
--cc=bcrl@redhat.com \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.