All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Hansen <haveblue@us.ibm.com>
To: linux-kernel@vger.kernel.org
Subject: [PATCH] Removal of big kernel lock from isdn drivers
Date: Wed, 06 Feb 2002 15:44:09 -0800	[thread overview]
Message-ID: <3C61BFC9.8030905@us.ibm.com> (raw)

I've been examining the continuing additions of the big kernel lock 
(BKL) to the 2.5 tree.  I noticed that in 2.5.3, the ISDN subsystem 
added the BKL to several places.  In response to this, I have written 
several patches to attempt removal of the BKL from the ISDN subsystem. 
I have little knowledge of the drivers themselves, so I would like some 
assistance from those of you who understand them better.  I probably 
have an over-simplified view of the code, so my patches may be too 
simplistic.  They're a bit big, so I've made them available here:
http://www.sr71.net/ibm/isdn/

isdn.bkl-remove.ippp_lock.patch:
   http://www.sr71.net/ibm/isdn/isdn.bkl-remove.isdn_dev_sem.patch
   added ippp_lock to ippp_struct
   * It appeared that the BKL was being used to guard the file struct's
     private data field, which is a ippp_struct.  I added a semaphore to
     that structure which can be locked instead of the BKL.

isdn.bkl-remove.hydsn_cards_sem.patch:
   http://www.sr71.net/ibm/isdn/isdn.bkl-remove.hydsn_cards_sem.patch
   adds rwsemaphore hydsn_cards_sem
* hydsn_cards_sem guards the card_root list.  It is a read/write
   semaphore which must be held for write when modifying the list.

isdn.bkl-remove.isdn_dev_rwsem.patch:
http://www.sr71.net/ibm/isdn/isdn.bkl-remove.ppp_lock.patch
* changes name of "dev" to "isdn_dev"
      - If there are going to be global variables,
        they can at least not have exceedingly generic
        names like "dev"!
* adds global isdn_dev_rwsem
      - isdn_dev_rwsem must be held when manipulating "isdn_dev"

I know that these patches should probably be separate, but this is 
easier for me.

-- 
Dave Hansen
haveblue@us.ibm.com




                 reply	other threads:[~2002-02-06 23:45 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3C61BFC9.8030905@us.ibm.com \
    --to=haveblue@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.