From: "Udo A. Steinberg" <reality@delusion.de>
To: Linus Torvalds <torvalds@transmeta.com>,
Linux Kernel <linux-kernel@vger.kernel.org>,
greg@kroah.com
Subject: [PATCH] Linux-2.5.4-pre6 uhci.c compile fix
Date: Mon, 11 Feb 2002 03:37:22 +0100 [thread overview]
Message-ID: <3C672E62.702FFB3C@delusion.de> (raw)
Hi Linus, Greg,
The attached patch fixes a trivial compiler warning in uhci.c:
uhci.c: In function `uhci_unlink_generic':
uhci.c:1694: warning: suggest parentheses around && within ||
Regards,
Udo.
diff -X dontdiff -Naur linux-2.5.4-pre-vanilla/drivers/usb/uhci.c linux-2.5.4-pre/drivers/usb/uhci.c
--- linux-2.5.4-pre-vanilla/drivers/usb/uhci.c Mon Feb 11 03:04:17 2002
+++ linux-2.5.4-pre/drivers/usb/uhci.c Mon Feb 11 03:11:47 2002
@@ -1689,8 +1689,8 @@
/* Control and Isochronous ignore the toggle, so this */
/* is safe for all types */
- if ((!(td->status & TD_CTRL_ACTIVE) &&
- (uhci_actual_length(td->status) < uhci_expected_length(td->info)) ||
+ if (((!(td->status & TD_CTRL_ACTIVE) &&
+ (uhci_actual_length(td->status) < uhci_expected_length(td->info))) ||
tmp == head)) {
usb_settoggle(urb->dev, uhci_endpoint(td->info),
uhci_packetout(td->info),
next reply other threads:[~2002-02-11 2:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-02-11 2:37 Udo A. Steinberg [this message]
2002-02-11 3:11 ` [PATCH] Linux-2.5.4-pre6 uhci.c compile fix Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3C672E62.702FFB3C@delusion.de \
--to=reality@delusion.de \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.