All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Weber <weber@nyc.rr.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Pete Zaitcev <zaitcev@redhat.com>, linux-kernel@vger.kernel.org
Subject: Re: Linux 2.5.4 Sound Driver Problem
Date: Mon, 11 Feb 2002 13:13:22 -0500	[thread overview]
Message-ID: <3C6809C2.1030808@nyc.rr.com> (raw)
In-Reply-To: <E16aKwN-0007Ro-00@the-village.bc.nu>

Alan Cox wrote:
>>>The sound_alloc_dmap() function in dmabuf.c must be changed from using 
>>>__get_free_pages() and virt_to_bus() -> pci_alloc_consistent().
>>>
>>What the hell are you talking about, I changed it long ago.
>>Linus uses ymfpci on his Crusoe Picturebook with no problems.
>>What is your kernel version?
>>
> 
> In the ymfpci case its not the sound_alloc_dmap (at least not in 2.4 but
> 2.5 might be out of date except in -dj). Its the use of virt_to_bus still
> rather than the handles returned from the pci api
> 
> 

I am looking at both 2.5.4 and 2.4.18-pre9.

In my copy of sound_alloc_dmap(), I see a direct call to 
__get_free_pages to allocate the buffer and a call to virt_to_bus.  I 
just thought that this could be cleared up by using pci_alloc_consistent 
(since this function will call __get_free_pages anyway and eliminates 
the need to use virt_to_bus).

Anyway, I'm not sure I understand this.  I know using the virt_to_bus is 
wrong, but why would we use __get_free_pages() here?  (This is not a 
rhetorical question, I honestly want to learn).


  reply	other threads:[~2002-02-11 18:14 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <mailman.1013448601.14957.linux-kernel2news@redhat.com>
2002-02-11 17:46 ` Linux 2.5.4 Sound Driver Problem Pete Zaitcev
2002-02-11 18:12   ` Alan Cox
2002-02-11 18:13     ` John Weber [this message]
2002-02-11 18:27       ` Pete Zaitcev
2002-02-11 18:48         ` John Weber
     [not found]         ` <3C6816EC.2040406@nyc.rr.com>
2002-02-11 19:21           ` Pete Zaitcev
     [not found] <fa.c0t1afv.1f02hrj@ifi.uio.no>
     [not found] ` <fa.jvah72v.1h34cqd@ifi.uio.no>
2002-02-11 19:58   ` John Weber
2002-02-11 20:42     ` John Weber
2002-02-11 17:27 John Weber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3C6809C2.1030808@nyc.rr.com \
    --to=weber@nyc.rr.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=zaitcev@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.