Re: [PATCH] printk prefix cleanups.

[Jeff Garzik <jgarzik@mandrakesoft.com>]

Zwane Mwaikambo wrote:
> 
> On Tue, 12 Feb 2002, Pete Zaitcev wrote:
> 
> > > Here is a simple patch which reduces resultant binary size by 1.2k for
> > > this particular module (opl3sa2). [...]
> >
> > >  #define OPL3SA2_MODULE_NAME        "opl3sa2"
> > > +#define OPL3SA2_PFX                OPL3SA2_MODULE_NAME ": "
> >
> > > -                   printk(KERN_ERR "opl3sa2: MSS mixer not installed?\n");
> > > +                   printk(KERN_ERR OPL3SA2_PFX "MSS mixer not installed?\n");
> >
> > I do not believe that it shortens binaries. Care to quote
> > size(1) output and /proc/modules with and without the patch?
> 
> It does _not_ reduce the memory footprint, that i knew before doing the
> patch, the only thing it does do is reduce the resultant binary's
> filesize. Surely thats worth it just for the space saving? size(1) reports
> the same sizes for both patched and unpatched.

If size(1) reports the same size, then no.

But I would still support a patch that added just 'PFX' to the driver...

	Jeff


-- 
Jeff Garzik      | "I went through my candy like hot oatmeal
Building 1024    |  through an internally-buttered weasel."
MandrakeSoft     |             - goats.com