All of lore.kernel.org
 help / color / mirror / Atom feed
From: Martin Dalecki <dalecki@evision-ventures.com>
To: Pavel Machek <pavel@suse.cz>
Cc: Vojtech Pavlik <vojtech@suse.cz>, Jens Axboe <axboe@suse.de>,
	kernel list <linux-kernel@vger.kernel.org>,
	torvalds@transmeta.com
Subject: Re: IDE cleanup for 2.5.4-pre3
Date: Sat, 16 Feb 2002 10:38:14 +0100	[thread overview]
Message-ID: <3C6E2886.8070600@evision-ventures.com> (raw)
In-Reply-To: <20020208231346.GA1209@elf.ucw.cz> <20020211094230.E1957@suse.de> <20020211134443.GC20854@atrey.karlin.mff.cuni.cz> <20020211181013.K729@suse.de> <20020213225326.A10409@suse.cz> <20020214094046.B37@toy.ucw.cz> <3C6CC19C.3040608@evision-ventures.com> <20020215204510.GD5019@atrey.karlin.mff.cuni.cz>

Pavel Machek wrote:

>Hi!
>
>>It seems bigger as it is at first glance, however if you start to read 
>>it at ide.h, the rest should
>>be, well,  obivous...
>>
>
>Ouch, its *big*. You should probably start pushing it to Jens ASAP,
>because if you'll clean up it a bit more, you'll end with really big
>patch which rewrites whole drivers/ide... [Not that it would be a bad
>thing.]
>

Well the atomic part of the patch is rather small if you look at it. But 
in hell unfortunately there is
no way around to make the consequences smaller. I would be much happier 
if it could be
done otherway around... but I see no way if one want's to preserve the 
drivers in a functional state.

>My favourite cleanup would be 
>
>struct ide_drive_s {} ide_drive_t;
>
>=>
>
>struct ide_drive {};
>
>and replacing all ide_drive_t with struct ide_drive...
>

That will happen.




  parent reply	other threads:[~2002-02-16  9:38 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-02-08 23:13 IDE cleanup for 2.5.4-pre3 Pavel Machek
2002-02-11  8:42 ` Jens Axboe
2002-02-11 13:44   ` Pavel Machek
2002-02-11 17:10     ` Jens Axboe
2002-02-13 21:53       ` Vojtech Pavlik
2002-02-14  9:40         ` Pavel Machek
2002-02-15  8:06           ` Martin Dalecki
2002-02-15 12:20             ` Vojtech Pavlik
2002-02-15 12:24               ` Martin Dalecki
2002-02-15 12:37                 ` Vojtech Pavlik
2002-02-15 20:45             ` Pavel Machek
2002-02-15 21:24               ` Vojtech Pavlik
2002-02-16  9:39                 ` Martin Dalecki
2002-02-16  9:38               ` Martin Dalecki [this message]
2002-02-16 18:22                 ` Andre Hedrick
2002-02-16 21:51                   ` Martin Dalecki
     [not found]               ` <Pine.LNX.4.10.10202151719420.10501-100000@master.linux-ide.org>
2002-02-16 22:46                 ` Pavel Machek
2002-02-17 13:52             ` Pavel Machek
2002-02-19 10:13               ` Martin Dalecki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3C6E2886.8070600@evision-ventures.com \
    --to=dalecki@evision-ventures.com \
    --cc=axboe@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pavel@suse.cz \
    --cc=torvalds@transmeta.com \
    --cc=vojtech@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.