Pete Zaitcev wrote: >>From: Linus Torvalds >>Date: 2002-02-13 16:47:33 >>Subject: Re: PATCH 2.5.4 i810_audio, bttv, working at all. >> > >>On Wed, 13 Feb 2002, Jeff Garzik wrote: >> >>>These changes are wrong. The addresses desired need to be obtained from >>>the pci_alloc_consistent return values. >>> >>Let's face it, people won't care about the complex PCI interfaces unless >>they give you something useful. >> > > I cannot believe that I am reading that. The pinhead penguin > is totally off the thread. The fix for i810 took me less than > 10 minutes, and it works perfectly! What the hell are you > talking about here? What complex interfaces?! Is this a list > for kernel programmers or milksuckers? The interface is > simple as a pancake! > > -- Pete > > P.S. Doug, for heaven's sake, push the fix upstrem ASAP, please. > I cannot stand this stupidity and incompetence anymore. > > P.P.S. Posting this FOR THE THIRD TIME in reply for a broken > patch. Next guy to post a broken "fix" for i810 with > isa_virt_to_bus or virt_to_phis may suffer very badly. I agree that the patch is the correct fix. All except for the line changing the remap_page_range() call it's also totally relevant to the 2.4 kernel driver. -- Doug Ledford http://people.redhat.com/dledford Please check my web site for aic7xxx updates/answers before e-mailing me about problems