From: "Kip Walker" <kwalker@broadcom.com>
To: linux-mips@oss.sgi.com
Subject: init_idle reaped before final call
Date: Tue, 05 Mar 2002 11:58:23 -0800 [thread overview]
Message-ID: <3C85235F.B59286EA@broadcom.com> (raw)
[cross-posted to linux-kernel in a separate mail (oops)]
I'm working with a (approximately) 2.4.17 kernel from the mips-linux
tree (oss.sgi.com).
I'd like to propose removing the "__init" designation from init_idle in
kernel/sched.c, since this is called from rest_init via cpu_idle.
Notice that rest_init isn't in an init section, and explicitly mentions
that it's avoiding a race with free_initmem. In my kernel (an SMP
kernel running on a system with only 1 available CPU), cpu_idle isn't
getting called until after free_initmem().
My CPU is MIPS, but it looks like x86 could experience the same problem.
Kip
Index: kernel/sched.c
===================================================================
RCS file:
/projects/bbp/cvsroot/systemsw/linux/src/kernel/kernel/sched.c,v
retrieving revision 1.10
diff -u -r1.10 sched.c
--- kernel/sched.c 2002/01/15 04:13:43 1.10
+++ kernel/sched.c 2002/03/05 19:40:14
@@ -1304,7 +1304,7 @@
extern unsigned long wait_init_idle;
-void __init init_idle(void)
+void init_idle(void)
{
struct schedule_data * sched_data;
sched_data = &aligned_data[smp_processor_id()].schedule_data;
next reply other threads:[~2002-03-05 20:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-03-05 19:58 Kip Walker [this message]
-- strict thread matches above, loose matches on Subject: below --
2002-03-05 22:06 init_idle reaped before final call Thomas Hood
2002-03-06 3:57 ` Keith Owens
2002-03-05 19:56 Kip Walker
2002-03-05 21:57 ` Martin J. Bligh
2002-03-05 22:15 ` Kip Walker
2002-03-05 23:33 ` Justin Carlson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3C85235F.B59286EA@broadcom.com \
--to=kwalker@broadcom.com \
--cc=linux-mips@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.