All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@zip.com.au>
To: lkml <linux-kernel@vger.kernel.org>
Subject: aa-200-active_page_swapout
Date: Tue, 19 Mar 2002 20:03:29 -0800	[thread overview]
Message-ID: <3C980A11.AD5A7660@zip.com.au> (raw)

Last one.


Don't bother checking for active pages in the swapout path.

Not sure about this one.  Clearly the page isn't *likely* to be on the
active list, because the caller found it on the inactive list.  But I
don't see any locking which would prevent the page from getting bumped
up to the active list in the meanwhile.

Needs more explanation.


=====================================

--- 2.4.19-pre3/mm/vmscan.c~aa-200-active_page_swapout	Tue Mar 19 19:49:04 2002
+++ 2.4.19-pre3-akpm/mm/vmscan.c	Tue Mar 19 19:49:04 2002
@@ -83,10 +83,6 @@ static inline int try_to_swap_out(struct
 		return 0;
 	}
 
-	/* Don't bother unmapping pages that are active */
-	if (PageActive(page))
-		return 0;
-
 	/* Don't bother replenishing zones not under pressure.. */
 	if (!memclass(page_zone(page), classzone))
 		return 0;

-

             reply	other threads:[~2002-03-20  4:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-03-20  4:03 Andrew Morton [this message]
2002-03-20 13:50 ` aa-200-active_page_swapout Rik van Riel
2002-03-20 19:24   ` aa-200-active_page_swapout Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3C980A11.AD5A7660@zip.com.au \
    --to=akpm@zip.com.au \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.