From: Todd Inglett <tinglett@vnet.ibm.com>
To: Thomas Hood <jdthood@mail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: proc_file_read() hack?
Date: Thu, 28 Mar 2002 09:29:55 -0600 [thread overview]
Message-ID: <3CA336F3.2080002@vnet.ibm.com> (raw)
In-Reply-To: <20020323114004.92117.qmail@web10307.mail.yahoo.com> <3C9F69F4.3010908@vnet.ibm.com> <1017085557.5263.335.camel@thanatos> <3CA20EDF.7080402@vnet.ibm.com> <1017277343.865.32.camel@thanatos>
Thomas Hood wrote:
>>If that is true I am wondering how it could possibly be correct
>>since start will be used as a length which is greater than the
>>size of the page.
>>
>
> start will be used as an offset, not as a length.
>
> If you think the hack was a bad idea, I agree with you.
> But we can't change it without auditing all the proc read
> functions that use case #1.
Ahh...thanks for taking the trouble to answer all these questions :). I
obviously wasn't paying attention enough to see that start was *not*
used as a length. Sigh. Anyway, yes I agree we cannot patch this
without some serious review and I'm not going to volunteer today :).
-todd
next prev parent reply other threads:[~2002-03-28 15:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-03-23 11:40 proc_file_read() hack? J.D. Hood
2002-03-25 18:18 ` Todd Inglett
2002-03-25 19:45 ` Thomas Hood
2002-03-27 18:26 ` Todd Inglett
2002-03-28 1:02 ` Thomas Hood
2002-03-28 15:29 ` Todd Inglett [this message]
-- strict thread matches above, loose matches on Subject: below --
2002-03-22 14:34 Todd Inglett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3CA336F3.2080002@vnet.ibm.com \
--to=tinglett@vnet.ibm.com \
--cc=jdthood@mail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.