From: Jeff Garzik <jgarzik@mandrakesoft.com>
To: Stelian Pop <stelian.pop@fr.alcove.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
p_gortmaker@yahoo.com
Subject: Re: [PATCH 2.5.8-pre1] pcnet_cs compile fixes
Date: Thu, 04 Apr 2002 14:36:56 -0500 [thread overview]
Message-ID: <3CACAB58.2090702@mandrakesoft.com> (raw)
In-Reply-To: <20020404135411.GF9820@come.alcove-fr>
Stelian Pop wrote:
> This patch makes pcnet_cs compile again (removal of dev->rmem_start
> and dev->rmem_end).
>
> It compiles and works for me as intended, but maybe there is a cleaner
> fix by someone who understands better the netdevice internals...
>
>
> ===== drivers/net/pcmcia/pcnet_cs.c 1.7 vs edited =====
> --- 1.7/drivers/net/pcmcia/pcnet_cs.c Tue Feb 5 08:55:16 2002
> +++ edited/drivers/net/pcmcia/pcnet_cs.c Thu Apr 4 11:27:47 2002
> @@ -1460,7 +1460,8 @@
> struct e8390_pkt_hdr *hdr,
> int ring_page)
> {
> - void *xfer_start = (void *)(dev->rmem_start + (ring_page << 8)
> + void *xfer_start = (void *)(dev->mem_start + (TX_PAGES<<8)
> + + (ring_page << 8)
> - (ei_status.rx_start_page << 8));
the earlier poster was more correct: don't remove rmem_start, replacing
it with ei_status.rmem_{start,end}
Anyway, this patch is long completed already, and sent to Linus already.
Jeff
prev parent reply other threads:[~2002-04-04 19:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-04-04 13:54 [PATCH 2.5.8-pre1] pcnet_cs compile fixes Stelian Pop
2002-04-04 19:36 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3CACAB58.2090702@mandrakesoft.com \
--to=jgarzik@mandrakesoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=p_gortmaker@yahoo.com \
--cc=stelian.pop@fr.alcove.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.