All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Fry <kevin@carts.com>
To: linuxppc emb3dd3d list <linuxppc-embedded@lists.linuxppc.org>
Subject: Variable name inconsistancies / resources on building patches
Date: Fri, 12 Apr 2002 16:41:02 -0700	[thread overview]
Message-ID: <3CB7708E.63151603@carts.com> (raw)


Looking at 2.4.18, I see that the the variable in immap_8260.h  for the
SCC's Protocol-Specific Mode Register is called the scc_pmsr. All the
#defines for it are called SCC_PMSR_blah.

As you can see someone called it the pmsr instead of the psmr which it
should be. All of the code for the FCC's uses the correct acronym
however..

The code I look at and compile all uses the correct (incorrect) name for
the SCC PSMR, so should we bother to write a patch to fix this?  I'm
inclined to say yes, only because it's frustrating to me to program
drivers and such with incorrect names :)

Since this would be my first kernel patch, are there any resources on
how to build patches and against what, and who to submit em
too??? thanks!

Kevin Fry


** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/

                 reply	other threads:[~2002-04-12 23:41 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3CB7708E.63151603@carts.com \
    --to=kevin@carts.com \
    --cc=linuxppc-embedded@lists.linuxppc.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.