Re: Comparison of notail and notail,iicache(14) 2.4.19-pre7

[Manuel Krause <manuel.krause@mb.tu-ilmenau.de>]

On 04/26/2002 06:45 PM, Dieter Nützel wrote:

> On Friday 26 April 2002 13:41, Yury Yu. Rupasov wrote:
> 
>>Dieter Nützel wrote:
>>
>>>Manuel Krause wrote:
>>>
>>>[-]
>>>
>>>>What's really unclear is the problem with my
>>>>failing Netscape files on the living iicache-mounted FS...
>>>>
>>>I had one outlier with iicache-new-13 here, too.
>>>
>>>/etc/cups/ppds.dat
>>>
>>>couldn't be accessed. I reported back but got no response.
>>>
> 
> [-]
> 
>>>Next thing could be linux-2.4.19p6-compound-speedup.patch.
>>>Any version for -pre7 ready?
>>>
>>This patch should work with linux-2.4.19-pre7 as well.
>>
> 
> Yes, Yura.
> I tried it today and got one rejection with preempt+lock-break.
> fs/reiserfs/journal.c.rej
> 
[-]
> 
> Had that before but Chris and Oleg gave me advice.
> I tried it this way:
> 
> /* lock the current transaction */
> inline static void lock_journal(struct super_block *p_s_sb) {
>   PROC_INFO_INC( p_s_sb, journal.lock_journal );
>   debug_lock_break(1);
>   conditional_schedule();
>   down(&SB_JOURNAL(p_s_sb)->j_lock);
> }
> 
> /* unlock the current transaction */
> inline static void unlock_journal(struct super_block *p_s_sb) {
>   up(&SB_JOURNAL(p_s_sb)->j_lock);
> }
> 
> But then it seems to be _NOT_ preempt (+lock-break) save.
> System lock up (nothing in the logs, SysRq key didn't work) during 
> latencytest0.42-png write test. Read test worked.
> 
> Thanks,
> 	Dieter
> 
> 

Mmh, I made this adjustment in the patch, too, since the first speedup 
patches had been posted. I really don't know how serious this could be 
in this code context.

I had random hard locks,too, but blamed it to my degenerating hardware 
so far. Could anyone else advise on preempt+lock-break-awareness here?

The linux-2.4.19p6-compound-speedup.patch seems to be another measurable 
tick faster than Olegs first patchset. Maybe, I'll post some values on 
my setup over the weekend. I've had one faster run so far but it locked 
up without log hints... ;-))


Best regards,

Manuel