From: Dave Hansen <haveblue@us.ibm.com>
To: Russell King <rmk@arm.linux.org.uk>
Cc: Arjan van de Ven <arjanv@redhat.com>, linux-kernel@vger.kernel.org
Subject: Re: devfs: BKL *not* taken while opening devices
Date: Tue, 30 Apr 2002 09:42:32 -0700 [thread overview]
Message-ID: <3CCEC978.2090602@us.ibm.com> (raw)
In-Reply-To: <20020429141301.B16778@flint.arm.linux.org.uk> <3CCD672E.5040005@us.ibm.com> <3CCD811E.8689F4B0@redhat.com> <20020430134557.C26943@flint.arm.linux.org.uk>
Russell King wrote:
> On Mon, Apr 29, 2002 at 06:21:34PM +0100, Arjan van de Ven wrote:
>
>>I'm not convinced of that. It's not nearly a critical path and it's
>>better to get even the "dumb" drivers safe than to risk having big
>>security holes in there for years to come.
>
> Would it be worth dropping a BUG_ON(!kernel_locked()) in tty_open() to
> catch this type of error? The tty code heavily relies on the BKL.
>
> This way, such locking problems would get caught early, since everyone
> uses the tty code during boot, right?
I like the idea. But, while we're at it, does anyone have a good enough
grasp of locking the the TTY layer that we can start peeling some of the
BKL out of there? Somebody was doing tests over a serial console here
and the lockmeter data showed horrible BKL contention and hold times.
--
Dave Hansen
haveblue@us.ibm.com
next prev parent reply other threads:[~2002-04-30 16:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-04-29 13:13 devfs: BKL *not* taken while opening devices Russell King
2002-04-29 15:30 ` Dave Hansen
2002-04-29 17:21 ` Arjan van de Ven
2002-04-29 17:40 ` Roman Zippel
2002-04-29 17:46 ` Arjan van de Ven
2002-05-02 16:44 ` Alan Cox
2002-04-29 17:52 ` Dave Hansen
2002-04-30 12:45 ` Russell King
2002-04-30 16:42 ` Dave Hansen [this message]
2002-04-30 16:52 ` Arjan van de Ven
2002-04-30 16:58 ` Dave Hansen
2002-04-30 18:26 ` Martin J. Bligh
2002-04-30 17:03 ` Russell King
2002-05-11 0:45 ` Richard Gooch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3CCEC978.2090602@us.ibm.com \
--to=haveblue@us.ibm.com \
--cc=arjanv@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.