From: Andrew Morton <akpm@zip.com.au>
To: Linus Torvalds <torvalds@transmeta.com>
Cc: lkml <linux-kernel@vger.kernel.org>
Subject: [patch] unneeded readpage in block_symlink
Date: Thu, 02 May 2002 11:43:28 -0700 [thread overview]
Message-ID: <3CD188D0.772540DD@zip.com.au> (raw)
The new consistency checks in buffer.c are complaining about
block_symlink's ->readpage against an already uptodate
page.
--- 2.5.12/fs/buffer.c~block_symlink_fix Thu May 2 10:27:42 2002
+++ 2.5.12-akpm/fs/buffer.c Thu May 2 10:30:37 2002
@@ -2155,8 +2155,12 @@ int block_symlink(struct inode *inode, c
* ->i_size will be enough for everything) and zero it out.
* OTOH it's obviously correct and should make the page up-to-date.
*/
- err = mapping->a_ops->readpage(NULL, page);
- wait_on_page_locked(page);
+ if (!PageUptodate(page)) {
+ err = mapping->a_ops->readpage(NULL, page);
+ wait_on_page_locked(page);
+ } else {
+ unlock_page(page);
+ }
page_cache_release(page);
if (err < 0)
goto fail;
I've also received a report of a dirty unmapped buffer outside
i_size with ext3. But that was against the rd.c driver, which
seems to be bust in 2.5. This will take some hunting down.
-
reply other threads:[~2002-05-02 18:42 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3CD188D0.772540DD@zip.com.au \
--to=akpm@zip.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.