All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@zip.com.au>
To: Linus Torvalds <torvalds@transmeta.com>
Cc: lkml <linux-kernel@vger.kernel.org>
Subject: [patch 1/10] suppress allocation warnings for radix-tree allocations
Date: Sun, 05 May 2002 13:53:01 -0700	[thread overview]
Message-ID: <3CD59BAD.37BD6A51@zip.com.au> (raw)



The recently-added page allocation failure warning generates a lot of
noise due to radix-tree node allocation failures.  Those messages are
not interesting.

But I think the warning is otherwise useful - "I got an allocation
failure and then it crashed" is better than "it crashed".

The patch suppresses the message for ratnode allocation failures.



=====================================

--- 2.5.13/mm/vmscan.c~radix-tree-warning	Sun May  5 13:31:59 2002
+++ 2.5.13-akpm/mm/vmscan.c	Sun May  5 13:31:59 2002
@@ -58,6 +58,7 @@ swap_out_add_to_swap_cache(struct page *
 	int ret;
 
 	current->flags &= ~PF_MEMALLOC;
+	current->flags |= PF_RADIX_TREE;
 	ret = add_to_swap_cache(page, entry);
 	current->flags = flags;
 	return ret;
--- 2.5.13/mm/page_alloc.c~radix-tree-warning	Sun May  5 13:31:59 2002
+++ 2.5.13-akpm/mm/page_alloc.c	Sun May  5 13:32:36 2002
@@ -396,8 +396,11 @@ rebalance:
 				return page;
 		}
 nopage:
-		printk("%s: page allocation failure. order:%d, mode:0x%x\n",
-			current->comm, order, gfp_mask);
+		if (!(current->flags & PF_RADIX_TREE)) {
+			printk("%s: page allocation failure."
+				" order:%d, mode:0x%x\n",
+				current->comm, order, gfp_mask);
+		}
 		return NULL;
 	}
 
--- 2.5.13/include/linux/sched.h~radix-tree-warning	Sun May  5 13:31:59 2002
+++ 2.5.13-akpm/include/linux/sched.h	Sun May  5 13:32:15 2002
@@ -371,6 +371,7 @@ do { if (atomic_dec_and_test(&(tsk)->usa
 #define PF_MEMDIE	0x00001000	/* Killed for out-of-memory */
 #define PF_FREE_PAGES	0x00002000	/* per process page freeing */
 #define PF_FLUSHER	0x00004000	/* responsible for disk writeback */
+#define PF_RADIX_TREE	0x00008000	/* debug: performing radix tree alloc */
 
 /*
  * Ptrace flags

-

             reply	other threads:[~2002-05-05 20:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-05-05 20:53 Andrew Morton [this message]
2002-05-05 21:51 ` [patch 1/10] suppress allocation warnings for radix-tree allocations Daniel Phillips
2002-05-05 22:06   ` Andrew Morton
2002-05-05 22:51     ` Anton Altaparmakov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3CD59BAD.37BD6A51@zip.com.au \
    --to=akpm@zip.com.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.