From: Jeff Garzik <jgarzik@mandrakesoft.com>
To: Zwane Mwaikambo <zwane@linux.realnet.co.sz>
Cc: twaugh@redhat.com, Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] parport irq sharing
Date: Thu, 09 May 2002 10:10:09 -0400 [thread overview]
Message-ID: <3CDA8341.6070706@mandrakesoft.com> (raw)
In-Reply-To: <Pine.LNX.4.44.0205091416280.6271-100000@netfinity.realnet.co.sz>
Zwane Mwaikambo wrote:
>--- linux-2.4.19-pre-ac/drivers/parport/parport_pc.c Mon Apr 8 21:36:20 2002
>+++ linux-2.4.19-pre7-ac3/drivers/parport/parport_pc.c Thu May 9 08:19:32 2002
>@@ -2355,7 +2355,7 @@
>
> if (p->irq != PARPORT_IRQ_NONE) {
> if (request_irq (p->irq, parport_pc_interrupt,
>- 0, p->name, p)) {
>+ SA_SHIRQ, p->name, p)) {
> printk (KERN_WARNING "%s: irq %d in use, "
> "resorting to polled operation\n",
> p->name, p->irq);
>
I don't think you want to do this unconditionally... probably breaks
older setups.
>
>--- linux-2.4.19-pre7-ac3/drivers/parport/parport_serial.c.orig Sun May 5 14:24:36 2002
>+++ linux-2.4.19-pre7-ac3/drivers/parport/parport_serial.c Thu May 9 09:46:58 2002
>@@ -249,7 +249,7 @@
> int success = 0;
>
> if (cards[i].preinit_hook &&
>- cards[i].preinit_hook (dev, PARPORT_IRQ_NONE, PARPORT_DMA_NONE))
>+ cards[i].preinit_hook (dev, dev->irq, PARPORT_DMA_NONE))
> return -ENODEV;
>
> for (n = 0; n < cards[i].numports; n++) {
>
If parport_serial is 100% PCI (I'm too lazy to check), this should be ok...
Jeff
next prev parent reply other threads:[~2002-05-09 14:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-05-09 12:18 [PATCH] parport irq sharing Zwane Mwaikambo
2002-05-09 14:10 ` Jeff Garzik [this message]
2002-05-09 14:03 ` Zwane Mwaikambo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3CDA8341.6070706@mandrakesoft.com \
--to=jgarzik@mandrakesoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=twaugh@redhat.com \
--cc=zwane@linux.realnet.co.sz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.