From: Andrew Morton <akpm@zip.com.au>
To: Dave Hansen <haveblue@us.ibm.com>
Cc: matthew@wil.cx, linux-kernel@vger.kernel.org
Subject: Re: fs/locks.c BKL removal
Date: Fri, 10 May 2002 16:17:29 -0700 [thread overview]
Message-ID: <3CDC5509.DCAF336A@zip.com.au> (raw)
In-Reply-To: <3CDC4037.8040104@us.ibm.com> <3CDC45EF.9000506@us.ibm.com>
Dave Hansen wrote:
>
> As Linus pointed out, a semaphore is probably the wrong way to go.
> The only things that really needs to be protected are the list
> operations themselves.
>
It was I who put the BKL back into locks.c, much to
Matthew's disgust...
The problem was that replacing the BKL with a semaphore
seriously damaged Apache thoughput on 8-way. Apache
was using flock()-based synchronisation and replacing
a spin with a schedule just killed it.
So.. Apache isn't doing that any more, but it is an
instructive case. Replacing the BKL with a semaphore
can sometimes be a very bad thing.
See http://www.uwsg.iu.edu/hypermail/linux/kernel/0010.3/ -
search for "scalability"
-
next prev parent reply other threads:[~2002-05-10 23:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-05-10 21:48 fs/locks.c BKL removal Dave Hansen
2002-05-10 22:13 ` Dave Hansen
2002-05-10 23:17 ` Andrew Morton [this message]
2002-05-11 19:48 ` Matthew Wilcox
2002-05-11 19:45 ` Matthew Wilcox
2002-05-12 1:40 ` Dave Hansen
2002-05-12 2:07 ` Matthew Wilcox
[not found] ` <20020513171729.4165.qmail@thales.mathematik.uni-ulm.de>
2002-05-13 19:43 ` Matthew Wilcox
2002-05-13 23:15 ` Christian Ehrhardt
2002-05-13 23:18 ` Andreas Dilger
2002-05-14 9:02 ` Christian Ehrhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3CDC5509.DCAF336A@zip.com.au \
--to=akpm@zip.com.au \
--cc=haveblue@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.