From: Nicolas Aspert <Nicolas.Aspert@epfl.ch>
To: graeme fisher <graeme@2d3d.co.za>
Cc: linux-kernel@vger.kernel.org, Abraham vd Merwe <abraham@2d3d.co.za>
Subject: Re: Agpgart patch for the i845G
Date: Tue, 14 May 2002 09:42:20 +0200 [thread overview]
Message-ID: <3CE0BFDC.2020507@epfl.ch> (raw)
In-Reply-To: <3CE0C17B.F5037970@2d3d.co.za>
Hello
> The addresses are the same for the i830mp and i845g so instead of
> duplicating the code I just used the i830 setup functions for the 845g
> as well.
OK. I was just a bit worried by the fact that I could not find any docs
on this chipset (I have almost all Intel AGP docs so this is a bit
frustrating :-), but if it works for you, I guess the patch is OK ;-)
> Strictly speaking the comment that you referred to in your mail should
> be changed to reflect i845g and not i830mp.
:-))
Maybe add a few more comments to justify the fact that you call
intel_830mp_setup, s.t. people reading the code in a few months won't
ask themselves what the heck is this 845g stuff.
a+
Nicolas.
--
Nicolas Aspert Signal Processing Institute (ITS)
Swiss Federal Institute of Technology (EPFL)
prev parent reply other threads:[~2002-05-14 7:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-05-14 7:49 Agpgart patch for the i845G graeme fisher
2002-05-14 7:42 ` Nicolas Aspert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3CE0BFDC.2020507@epfl.ch \
--to=nicolas.aspert@epfl.ch \
--cc=abraham@2d3d.co.za \
--cc=graeme@2d3d.co.za \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.