All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Malek <dan@embeddededge.com>
To: Tom Rini <trini@kernel.crashing.org>
Cc: linuxppc-embedded@lists.linuxppc.org
Subject: Re: [PATCH 2.5] More i8259 cleanups
Date: Wed, 15 May 2002 16:43:57 -0400	[thread overview]
Message-ID: <3CE2C88D.6010908@embeddededge.com> (raw)
In-Reply-To: 20020515171104.GQ721@opus.bloom.county


Tom Rini wrote:

> Hey all.  I've been doing more OpenPIC/i8259 work and here's the next
> patch I'll be pushing to linuxppc-2.5 soon.

Looks good.....just one little thing, how about we wrap some more of these
functions with __init attributes?  There are a bunch of these couple of
line functions, like openpic_enable_sie(), that are only called from the
init function.  That's one of the reasons I originally surrounded them
by ifdefs......probably doesn't amount to much, but it is at least logically
consistent since the function(s) that call them are also __init's :-)

Thanks.


	-- Dan


** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/

  reply	other threads:[~2002-05-15 20:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-05-15 17:11 [PATCH 2.5] More i8259 cleanups Tom Rini
2002-05-15 20:43 ` Dan Malek [this message]
2002-05-15 21:36   ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3CE2C88D.6010908@embeddededge.com \
    --to=dan@embeddededge.com \
    --cc=linuxppc-embedded@lists.linuxppc.org \
    --cc=trini@kernel.crashing.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.