From: Andrew Morton <akpm@zip.com.au>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Ghozlane Toumi <ghoz@sympatico.ca>,
linux-kernel@vger.kernel.org, torvalds@transmeta.com
Subject: Re: [PATCH] Fix BUG macro
Date: Thu, 16 May 2002 19:41:58 -0700 [thread overview]
Message-ID: <3CE46DF6.62EF67E0@zip.com.au> (raw)
In-Reply-To: Your message of "Thu, 16 May 2002 12:27:55 -0400." <20020516162841.PYWL19243.tomts15-srv.bellnexxia.net@there> <E178XQX-0000tw-00@wagner.rustcorp.com.au>
Rusty Russell wrote:
>
> ...
> __asm__ __volatile__( "ud2\n" \
> "\t.word %c0\n" \
> "\t.long %c1\n" \
> - : : "i" (__LINE__), "i" (__FILE__))
> + "\t.long %c2\n" \
> + : : "i" (__LINE__), \
> + "i" (__stringify(KBUILD_BASENAME)), \
> + "i" (__FUNCTION__))
I'd share Hugh's concern on this one. Adding the name of the
containing function to every BUG() expansion will increase
the size of .rodata.
Do you have before-and-after /usr/bin/size output?
-
next prev parent reply other threads:[~2002-05-17 2:38 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-05-16 8:08 [PATCH] Fix BUG macro Rusty Russell
2002-05-16 11:21 ` Hugh Dickins
2002-05-17 0:31 ` Rusty Russell
2002-05-17 7:56 ` Hugh Dickins
2002-05-17 9:43 ` Rusty Russell
2002-05-17 11:47 ` Hugh Dickins
2002-05-17 12:02 ` Andreas Schwab
2002-05-17 12:46 ` Rusty Russell
2002-05-17 13:19 ` Hugh Dickins
2002-05-16 16:27 ` Ghozlane Toumi
2002-05-17 2:25 ` Rusty Russell
2002-05-17 2:41 ` Andrew Morton [this message]
2002-05-17 4:25 ` Rusty Russell
2002-05-17 4:50 ` Andrew Morton
2002-05-17 5:20 ` Rusty Russell
2002-05-17 6:44 ` Andrew Morton
2002-05-17 9:39 ` Rusty Russell
2002-05-17 16:14 ` Kai Germaschewski
2002-05-17 18:41 ` Andrew Morton
2002-05-17 22:35 ` Stevie O
2002-05-17 23:09 ` Kai Germaschewski
2002-05-18 6:28 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3CE46DF6.62EF67E0@zip.com.au \
--to=akpm@zip.com.au \
--cc=ghoz@sympatico.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.