From: Martin Dalecki <dalecki@evision-ventures.com>
To: Russell King <rmk@arm.linux.org.uk>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] SLC82C105 IDE driver: missing __init
Date: Wed, 22 May 2002 10:40:46 +0200 [thread overview]
Message-ID: <3CEB598E.1090100@evision-ventures.com> (raw)
In-Reply-To: <20020522091648.GB312@pazke.ipt> <20020522103602.A15750@flint.arm.linux.org.uk>
Uz.ytkownik Russell King napisa?:
> On Wed, May 22, 2002 at 01:16:48PM +0400, Andrey Panin wrote:
>
>>slc82c105_bridge_revision() functions lacks __init modifier.
>>Attached patch (against 2.5.17) fixes it.
>>Compiles, but untested. Please consider applying.
>
>
> I'm surprised it compiles.
I'm not :-). I wouldn't be even surprised if it works by accident...
> I've got a rather major update to it here,
> but I need to find time to pull it out of the ARM patch, and I need IDE
> to settle down a bit so the two are actually in sync with each other.
> (Martin messed up my DMA changes which'd prevent sl82c105 linking - I'm
> waiting for the fix to emerge, which I think is in 2.5.17, but the TLB
It should indeed be all in place right now. Other then this: If you feel like
something in the generic code has to be changed - don't hessitate just
do it. We can always sort it out.
> stuff in 2.5.17 has broken all my ARM builds, so I'm unable to build or
> test anything on 2.5 currently.)
Just to make it clean - this time it was not me ;-).
>
> Too many things to do... too many problems to solve... too many patches
> to look at... too much email... not enough hours in the day... not enough
> fast machines to build kernels on... not enough rmk clones to run kernel
> tests... 8)
next prev parent reply other threads:[~2002-05-22 9:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-05-22 9:16 [PATCH] SLC82C105 IDE driver: missing __init Andrey Panin
2002-05-22 9:36 ` Russell King
2002-05-22 8:40 ` Martin Dalecki [this message]
2002-05-22 13:10 ` Alan Cox
2002-05-22 14:09 ` Andrey Panin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3CEB598E.1090100@evision-ventures.com \
--to=dalecki@evision-ventures.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.