From: Martin Dalecki <dalecki@evision-ventures.com>
To: Vojtech Pavlik <vojtech@suse.cz>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] duplicate clock calculation code in 3 IDE drivers
Date: Wed, 22 May 2002 10:42:10 +0200 [thread overview]
Message-ID: <3CEB59E2.7020307@evision-ventures.com> (raw)
In-Reply-To: <20020522093013.GD312@pazke.ipt> <20020522114206.D31145@ucw.cz>
Uz.ytkownik Vojtech Pavlik napisa?:
> On Wed, May 22, 2002 at 01:30:13PM +0400, Andrey Panin wrote:
>
>>Hi,
>>
>>now it is more interesting patch. AMD, PIIX and VIA IDE drivers contain
>>some duplicated code for (amd|piix|via)_clock calculation. Attached
>>patch moves this code into one function in ata-timing.c file.
>>
>>Please take a look at it.
>
>
> Looks quite OK - though it'd be better if "system_bus_speed" already
> could be giving these reasonable values - this way we could get rid of
> the (amd|piix|via)_clock variables altogether.
Yes indeed this would be the "kings road".
Any one of you who cares enough?
next prev parent reply other threads:[~2002-05-22 9:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-05-22 9:30 [PATCH] duplicate clock calculation code in 3 IDE drivers Andrey Panin
2002-05-22 9:42 ` Vojtech Pavlik
2002-05-22 8:42 ` Martin Dalecki [this message]
2002-05-22 11:11 ` Vojtech Pavlik
[not found] ` <3CEB70F4.4030902@evision-ventures.com>
2002-05-22 11:36 ` [patch] Remove dead DISK_RECOVERY_TIME code Vojtech Pavlik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3CEB59E2.7020307@evision-ventures.com \
--to=dalecki@evision-ventures.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vojtech@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.