All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@zip.com.au>
To: Linus Torvalds <torvalds@transmeta.com>,
	lkml <linux-kernel@vger.kernel.org>, Jens Axboe <axboe@suse.de>
Subject: Re: [patch 1/16] unplugging fix
Date: Sun, 02 Jun 2002 00:38:58 -0700	[thread overview]
Message-ID: <3CF9CB92.A6BF921B@zip.com.au> (raw)
In-Reply-To: <3CF88852.BCFBF774@zip.com.au>

Andrew Morton wrote:
> 
> There's a plugging bug in 2.5.19.  Once you start pushing several disks
> hard, the new unplug code gets confused and queues are left in plugged
> state, but not on the plug list.  They never get unplugged and the
> machine dies mysteriously.
> 

This patch didn't fix it.  It made it tons better, but I again have a
wedged box.  Same symptoms - against IDE this time.

blk_plug_list is empty.  queue_flags=0x03.  Interestingly,
q->plug_list is non-empty, non-zero, both list members pointing at
a list which isn't either itself or blk_plug_list.

I note that the code isn't taking queues off the plug list when the queue
is destroyed.  Guess that doesn't matter - we never destroy a plugged
queue...

This one is killing me.

-

  reply	other threads:[~2002-06-02  7:35 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-06-01  8:39 [patch 1/16] unplugging fix Andrew Morton
2002-06-02  7:38 ` Andrew Morton [this message]
2002-06-02  8:12   ` Jens Axboe
2002-06-03  8:39     ` Jens Axboe
2002-06-03  9:14       ` Andrew Morton
2002-06-03  9:41         ` Jens Axboe
2002-06-03 19:27           ` Andrew Morton
2002-06-04  7:25             ` Jens Axboe
2002-06-04  8:09               ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3CF9CB92.A6BF921B@zip.com.au \
    --to=akpm@zip.com.au \
    --cc=axboe@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.